Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0 #111

Merged
merged 57 commits into from
Dec 22, 2023
Merged

v1.0 #111

merged 57 commits into from
Dec 22, 2023

Conversation

natemoo-re
Copy link
Owner

@natemoo-re natemoo-re commented Jun 6, 2023

Finally, [email protected] is here! This release provides a more flexible and reliable method of icon management, removes a number of redundant APIs, and now relies on Astro's official integration API.

Please see the Upgrade to astro-icon v1 guide for specific migration steps and the package README for more information.

MASSIVE thank you to @stramel for keeping this effort alive while I was too burned out to help.


Closes #87, closes #71, fixes #29, fixes #35, resolves #38, resolves #43, resolves #54, resolves #65, resolves #68, resolves #73

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: f5548cf

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 7:56pm
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 7:56pm

@nimser
Copy link

nimser commented Jun 6, 2023

No insights, but how does that solve #29 ? I'm still missing icons, e.g. bi:balloon-heart-fill.

@nimser nimser mentioned this pull request Jun 6, 2023
@vercel
Copy link

vercel bot commented Jun 6, 2023

Deployment failed with the following error:

Resource is limited - try again in 2 hours (more than 100, code: "api-deployments-free-per-day").

@Lunarequest
Copy link

Lunarequest commented Jun 12, 2023

hi so i tried using this with my project and discovered that this pr uses pnpm, yarn 2.x will not be able to install this package if it uses pnpm as yarn does not yet have a resolver for pnpm packages. see yarnpkg/berry#3169 for more info

@stramel
Copy link
Collaborator

stramel commented Jun 12, 2023

Thanks for the feedback @Lunarequest! We should hopefully have an alpha release here soon which will resolve the install problem for you.

@Lunarequest
Copy link

Thanks for the feedback @Lunarequest! We should hopefully have an alpha release here soon which will resolve the install problem for you.

thank you!

@alexanderniebuhr
Copy link

@stramel I was trying to install it via URL this https://gitpkg.now.sh/natemoo-re/astro-icon/packages/core?v1
While it does install, running astro dev would not work. Would be great if you can either release an preview version to npm or let me know how to install this branch and test it :)

Failed to resolve entry for package "astro-icon". The package may have incorrect main/module/exports specified in its package.json.

@stramel
Copy link
Collaborator

stramel commented Jun 19, 2023

@stramel I was trying to install it via URL this gitpkg.now.sh/natemoo-re/astro-icon/packages/core?v1 While it does install, running astro dev would not work. Would be great if you can either release an preview version to npm or let me know how to install this branch and test it :)

Failed to resolve entry for package "astro-icon". The package may have incorrect main/module/exports specified in its package.json.

Yes, we are wanting to get a prerelease on NPM so that people can start giving it a shot without the workaround. I unfortunately don't have the ability to release. The v1 branch doesn't have the built code published on it so it won't work. However the code state is in nearly the same spot as my ms/v1 branch that I previously posted about using. So you should be able to use that branch still.

github-actions bot and others added 2 commits December 22, 2023 00:41
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot and others added 2 commits December 22, 2023 08:05
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment