Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#78 prevent entering to SCROLLING state if both pan are disabled. #79

Merged
merged 1 commit into from
Jan 23, 2019
Merged

#78 prevent entering to SCROLLING state if both pan are disabled. #79

merged 1 commit into from
Jan 23, 2019

Conversation

nil2l
Copy link
Contributor

@nil2l nil2l commented Jan 16, 2019 •
edited by markusressel
Loading

fixes #78

@markusressel
Copy link
Collaborator

markusressel commented Jan 16, 2019 •
edited
Loading

Looks good to me, feel free to merge @natario1

@markusressel markusressel requested a review from natario1 January 16, 2019 23:35
@natario1
Copy link
Owner

Thanks!

@natario1 natario1 merged commit 5f41755 into natario1:master Jan 23, 2019
natario1 added a commit that referenced this pull request Jan 23, 2019
@natario1
Improve #79
ffc6e1d
natario1 added a commit that referenced this pull request Jan 23, 2019
@natario1
Feature/alignment (#76)
fc08082 
* Versions

* Add TRANSFORMATION_GRAVITY_AUTO

* Create Alignment class

* Create Alignment attrs and update Views

* Implement Alignment in checkPanBounds

* Update docs

* Remove checks to be consistent with docs

* Rename methods and fields

* Fix fling with Alignment.NONE

* Address review, move gravity logic to Alignment

* Improve #79
@nil2l nil2l deleted the issues/#78-disabled-pan-consumes-drag-gesture branch January 28, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natario1 natario1 natario1 approved these changes

Assignees
No one assigned
Labels
is:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled pan consumes drag gesture
3 participants
@nil2l @markusressel @natario1