Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled pan consumes drag gesture #78

Closed
nil2l opened this issue Jan 16, 2019 · 4 comments · Fixed by #79
Closed

Disabled pan consumes drag gesture #78

nil2l opened this issue Jan 16, 2019 · 4 comments · Fixed by #79
Labels
is:bug

Comments

@nil2l
Copy link
Contributor

nil2l commented Jan 16, 2019

Even if both pan are disabled ZoomEngine still consumes drag event (single pointer) though doesn't use it. So children can't get it to detect drag gesture as they receive ACTION_CANCEL because of onInterceptTouchEvent returning true.
nil2l pushed a commit to nil2l/ZoomLayout that referenced this issue Jan 16, 2019
natario1#78 prevent entering to SCROLLING state if both pan are disab…
1dd0a5d 
…led.
@markusressel
Copy link
Collaborator

markusressel commented Jan 16, 2019 •
edited
Loading

Thx for your interest! Looks good 👍
Can you create a PR for this?

@nil2l nil2l mentioned this issue Jan 16, 2019
Merged
@markusressel
Copy link
Collaborator

Ah you already did 😄 thx!

@nil2l
Copy link
Contributor Author

nil2l commented Jan 17, 2019

Yes, I thought github will bind them automatically as branch name and commit comment have #78 ref.

@markusressel
Copy link
Collaborator

You have to reference it in the PR description, then it will work 😊

natario1 pushed a commit that referenced this issue Jan 23, 2019
@nil2l @natario1
#78 prevent entering to SCROLLING state if both pan are disabled. (#79)
5f41755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#78 prevent entering to SCROLLING state if both pan are disabled. nil2l/ZoomLayout
2 participants
@nil2l @markusressel