Skip to content

Conversation

@rdblue
Copy link

@rdblue rdblue commented Jan 1, 2024

This fixes a couple of questions from the review, apache#9340.

  • Fixes temp view resolution
  • Applies the expected schema if needed, resolving columns by position only
  • Adds an Origin while parsing the view plan
  • Uses parseQuery instead of parsePlan to ensure the view text is a query and not a command
  • Relocates view methods in SparkCatalog
  • Rewrites function names and adds tests
  • Updates tests that were failing due to mismatched schemas
  • Adds extra test case for a view referencing a conflicting name (both temp view and permanent view)

@github-actions github-actions bot added the SPARK label Jan 1, 2024
@rdblue rdblue force-pushed the spark-view-read-support branch from 7e97ce3 to f0eece4 Compare January 2, 2024 02:58
Copy link
Owner

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this

@nastra nastra merged commit d8b7888 into nastra:spark-view-read-support Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants