Spark: Add support for reading Iceberg views #9340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
spark-view-read-support
branch
2 times, most recently
from
27566bd to
35a7c10
Compare
nastra
commented
Dec 19, 2023
...rk-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CreateViewAnalysis.scala
Outdated
Show resolved
Hide resolved
nastra
commented
Dec 19, 2023
...extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala
Outdated
Show resolved
Hide resolved
nastra
commented
Dec 19, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
nastra
commented
Dec 19, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
spark-view-read-support
branch
3 times, most recently
from
ab0c8a7 to
7f0e9bb
Compare
nastra
force-pushed
the
spark-view-read-support
branch
from
7f0e9bb to
7092eab
Compare
rdblue
reviewed
Dec 19, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
...extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
...extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
...ark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/V2ViewDescription.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 19, 2023
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
spark-view-read-support
branch
2 times, most recently
from
d937315 to
4b5baf5
Compare
nastra
force-pushed
the
spark-view-read-support
branch
from
4b5baf5 to
d397cb6
Compare
rdblue
reviewed
Dec 22, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 22, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 22, 2023
....5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 22, 2023
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 22, 2023
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java
Show resolved
Hide resolved
rdblue
reviewed
Dec 22, 2023
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 22, 2023
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 22, 2023
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
approved these changes
Jan 4, 2024
Contributor
|
Merged! Thanks for getting this working @nastra! |
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits out reading from views out of #9332 to make reviewing easier. Views are currently created using Iceberg's
ViewCatalogAPI to make the PR smaller and only focus about reading views.