Fix #85, add CmdCode to sch_lab_table #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-85-specify-cmdcode
branch
from
7df349c
to
e322916
Compare
jphickey
added
the
CCB:Ready
Allows the command/function code to be specified in the messages generated by SCH_LAB. This allows it to be used for testing apps that require a specific function code in the internal wakeup message.
jphickey
force-pushed
the
fix-85-specify-cmdcode
branch
from
e322916
to
2a00c3c
Compare
|
Add to the default table? More obvious to the user if the element is at minimum described there or provides an example (can be commented out). |
pepepr08
previously requested changes
Sep 7, 2021
astrogeco
removed
the
CCB:Ready
|
CCB:2021-09-08 APPROVED |
Adds an explicit initializtion of Function Code to 0 in the sample table, to demonstrate how a user can set the code nonzero if necessary.
pepepr08
approved these changes
Sep 8, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 8, 2021
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 10, 2021
**Combines** nasa/cFE#1939, v6.8.0-rc1+dev994 nasa/osal#1145, v5.1.0-rc1+dev604 nasa/PSP#307, v1.5.0-rc1+dev124 nasa/sch_lab#87, v2.4.0-rc1+dev47 **Includes** *cFE* nasa/cFE#1903, Update directory diagrams in application developer guide nasa/cFE#1922, SB code coverage improvements #1905, Improve SB coverage nasa/cFE#1936, Improve ES code coverage nasa/cFE#1938, Enforce minimum code coverage nasa/cFE#1940, Update dev guide for MSG and SBR nasa/cFE#1941, Support unimplemented features in MSG FT *osal* nasa/osal#1144, Regex update in coverage enforcement to match .0 nasa/osal#1142, Add typecast to memchr call *psp* nasa/PSP#307, check that module type is not invalid nasa/PSP#306, do not override add_psp_module for coverage test *sch_lab* nasa/sch_lab#86, add CmdCode to sch_lab_table nasa/sch_lab#88, Fix missing typedef Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Ariel Adams <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Allows the command/function code to be specified in the messages generated by SCH_LAB. This allows it to be used for testing apps that require a specific function code in the internal wakeup message.
Fixes #85
Testing performed
Validated that the feature works by using it to test BP app (which requires a specific code in it's wakeup MID)
Expected behavior changes
SCH_LAB now supports testing apps that require a specific function code in the generated wake up message
System(s) tested on
Ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.