Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #54, Use MSG APIs #55

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Nov 4, 2020

Describe the contribution
Replaces deprecated SB API's with MSG
Fix #54

Testing performed
Built and ran, enabled telemetry, checked noops

Expected behavior changes
None

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
nasa/cFE#777

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 4, 2020
@astrogeco
Copy link
Contributor

CCB 2020-11-12 APPROVED

@jphickey
Copy link
Contributor

FWIW - I am still of the opinion we should hold off on making changes to apps until we have the correct API alignment patterns/requirements settled as per nasa/cFE#1009 (comment)

(Or in other words, there might be a good reason to keep the local TLM union buffer around)

@astrogeco astrogeco added CCB-20201112 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Nov 13, 2020
@skliper
Copy link
Contributor Author

skliper commented Nov 17, 2020

Can this move forward? I'm doing changes for nasa/cFE#1009 on top of these... aka #56.

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we have agreement on the path forward here.

@astrogeco astrogeco changed the base branch from main to integration-candidate November 17, 2020 20:02
@astrogeco astrogeco merged commit 5786a55 into nasa:integration-candidate Dec 1, 2020
astrogeco added a commit to astrogeco/cFS that referenced this pull request Dec 1, 2020
astrogeco added a commit to astrogeco/cFS that referenced this pull request Dec 2, 2020
@skliper skliper deleted the fix54-use-msg-apis branch February 1, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies on deprecated SB APIs
3 participants