sample_app Integration candidate: Caelum-rc4+dev63 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-organize the source files to adhere to the recommended patterns.
…t-id-names Fix #188, Apply consistent Event ID names to common events
…ific-cfe-headers Fix #194, Remove component-specific cFE header #includes
…o-remove-multiple-returns Fix #197, Refactor SAMPLE_APP_Init/Process to remove multiple returns
…branch-in-SAMPLE_APP_Process Fix #199, Add test for missing branch in SAMPLE_APP_Process()
…structure Fix #141, Zero out global data structure during initialization
…-separate-files Fix #45, Move cmds and utils into separate files
Fix #207, organize source files according to current patterns
jphickey
added a commit
that referenced
this pull request
Oct 30, 2023
jphickey
force-pushed
the
integration-candidate
branch
from
a5c6b04
to
b7c1b4a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* This function Process Ground Station Command */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| int32 SAMPLE_APP_Process(const SAMPLE_APP_ProcessCmd_t *Msg) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| /* Output CRC */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void SAMPLE_APP_GetCrc(const char *TableName) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| /* Verify command packet length */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/ | ||
| bool SAMPLE_APP_VerifyCmdLength(CFE_MSG_Message_t *MsgPtr, size_t ExpectedLength) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 30, 2023
*Combines:* sample_app v1.3.0-rc4+dev56 ci_lab v2.5.0-rc4+dev51 sch_lab v2.5.0-rc4+dev61 **Includes:** *sample_app* - nasa/sample_app#189 - nasa/sample_app#195 - nasa/sample_app#198 - nasa/sample_app#201 - nasa/sample_app#205 - nasa/sample_app#208 - nasa/sample_app#209 *ci_lab* - nasa/ci_lab#148 *sch_lab* - nasa/sch_lab#151 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 30, 2023
*Combines:* sample_app v1.3.0-rc4+dev56 ci_lab v2.5.0-rc4+dev51 sch_lab v2.5.0-rc4+dev61 **Includes:** *sample_app* - nasa/sample_app#189 - nasa/sample_app#195 - nasa/sample_app#198 - nasa/sample_app#201 - nasa/sample_app#205 - nasa/sample_app#208 - nasa/sample_app#209 *ci_lab* - nasa/ci_lab#148 *sch_lab* - nasa/sch_lab#151 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
cFS Bundle Checks
PSP Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 22.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt
@jphickey