Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SAMPLE_APP_Init and SAMPLE_APP_Process to remove multiple returns #197

Closed
thnkslprpt opened this issue Mar 6, 2023 · 0 comments · Fixed by #198
Closed

Refactor SAMPLE_APP_Init and SAMPLE_APP_Process to remove multiple returns #197

thnkslprpt opened this issue Mar 6, 2023 · 0 comments · Fixed by #198

Comments

@thnkslprpt
Copy link
Contributor

Describe the bug
SAMPLE_APP_Init() and SAMPLE_APP_Process() use multiple returns to manage control flow.

Expected behavior
The Sample App should exhibit/encourage best practice (according to the cFS), of which multiple returns does not comply.
Given that it is unnecessary in this case, would be worth refactoring to the recommended pattern with a single exit point from the function.

Reporter Info
Avi Weiss @thnkslprpt
@thnkslprpt thnkslprpt mentioned this issue Mar 6, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue Oct 30, 2023
@dzbaker
Merge pull request #198 from thnkslprpt:fix-197-refactor-sample-app-t…
d5489a9 
…o-remove-multiple-returns

Fix #197, Refactor SAMPLE_APP_Init/Process to remove multiple returns
@dzbaker dzbaker mentioned this issue Oct 30, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #197, Refactor SAMPLE_APP_Init/Process to remove multiple returns thnkslprpt/sample_app
1 participant
@thnkslprpt