Fix #77, Standardize to SAMPLE_APP_ namespace prefix #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2020
jphickey
added
the
CCB:Ready
jphickey
force-pushed
the
fix-77-name-consistency
branch
from
bb230a9
to
61b06f1
Compare
skliper
approved these changes
Oct 27, 2020
astrogeco
added
CCB-20201028
and removed
CCB:Ready
zanzaben
approved these changes
Oct 28, 2020
|
CCB 2020-10-28 APPROVED |
Replace inconsistent SAMPLE_ and SAMPLE_App name prefixes, now all identifers should start with SAMPLE_APP_.
jphickey
force-pushed
the
fix-77-name-consistency
branch
from
61b06f1
to
ade058c
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Replace inconsistent SAMPLE_ and SAMPLE_App name prefixes, now all identifers should start with SAMPLE_APP_.
Fixes #77
Testing performed
Build and sanity test CFE
Run all unit tests
Expected behavior changes
No impact to behavior, but this also changes the name of the main function from SAMPLE_AppMain to SAMPLE_APP_Main which affects the CFE startup script.
System(s) tested on
Ubuntu 20.04
Additional context
Noticed a bug in the process of this name change - the
PipeNamefield was hardcoded at 16 bytes, and this change (adding 4 chars) made the name too long, which overran the buffer. Furthermore it was set withstrcpy(), notstrncpy()- so it clobbered the next field.This has also been fixed in this PR - changed to use
CFE_MISSION_MAX_API_LENandstrncpy().This also requires a corresponding update in SAMPLE_LIB as well as CFE startup script to fix the entry point names.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.