Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update startup script names to match SAMPLE_APP and SAMPLE_LIB #967

Closed
jphickey opened this issue Oct 27, 2020 · 0 comments · Fixed by #968
Closed

Update startup script names to match SAMPLE_APP and SAMPLE_LIB #967

jphickey opened this issue Oct 27, 2020 · 0 comments · Fixed by #968
Assignees
@jphickey
Labels
breaking enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
PR's nasa/sample_app#100 and nasa/sample_lib#34 update the function names to use a consistent prefix - SAMPLE_APP and SAMPLE_LIB, respectively.

The example startup script needs to change accordingly.

Describe the solution you'd like
Update entry point names.

Additional context
This is needed at the same time if/when the other two PRs are merged.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Oct 27, 2020
@jphickey jphickey mentioned this issue Oct 27, 2020
Merged
astrogeco added a commit that referenced this issue Nov 2, 2020
@astrogeco
Merge pull request #968 from jphickey/fix-967-startup-names
6a854e6 
Fix #967, Update startup script names
@astrogeco astrogeco added this to the 7.0.0 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
breaking enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #967, Update startup script names jphickey/cFE
2 participants
@jphickey @astrogeco