-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #795, Add uncovered vxworks source files to coverage statistics #826
Fix #795, Add uncovered vxworks source files to coverage statistics #826
Conversation
@jphickey Is this along the lines of what you'd expect? |
Yes! This looks good! The only comment is regarding the endian conversions - e.g. ntohl/s, etc - these are ones that I would consider falling back to "real" behavior - similar to memcpy/memset etc - if nothing is configured. Having it just return 0 by default might cause problems for some code. But in those cases I suppose someone can just be sure to set/register a return value in the test case. |
I think I left those out since host could be big or little endian, and preference might be a hook that emulates the real target? Just don't want testers to assume coverage testing w/ the test host endian is really appropriate in all cases. |
I do agree that if there is any conditional which depends on output of an endian conversion, that the test case should explicitly set that output, rather than assuming the stub is going to work like the real one does. So it's probably fine the way it is. |
CCB:2021-02-24 APPROVED
|
See #831 for follow-on to finish adding coverage |
9e4a8e5
to
b257683
Compare
@astrogeco squashed, ready for merge |
Combines: - nasa/cFE#1196 - nasa/osal#835 - nasa/elf2cfetbl#72 Includes: - nasa/cFE#1154 - nasa/cFE#935 - nasa/cFE#1179 - nasa/cFE#1140 - nasa/cFE#1178 - nasa/cFE#1197 - nasa/osal#834 - nasa/osal#826 - nasa/osal#827 - nasa/osal#829 - nasa/osal#824 - nasa/elf2cfetbl#71
Fix nasa#822, Remove iterator modification in loop
Describe the contribution
Fix #795 - Adds all the currently possible source files for vxworks to coverage statistics and adds coverage tests
Testing performed
Build and execute unit tests, passed
Expected behavior changes
None, but coverage now includes all currently possible files in vxworks build
System(s) tested on
Additional context
Not full coverage yet on os-impl-bsd-sockets.c (plan to keep improving prior to CCB)
Also will squash
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC