Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1153, Remove logic based on LogEnabled status #1178

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Feb 18, 2021

Describe the contribution
Fix #1153 - no longer utilizing the LogEnabled element in HK telemetry for EVS logic, log is always enabled in this implementation

Testing performed
Built and executed unit tests, passed

Expected behavior changes
No real change, but on failures (reset area or semaphore) will panic.

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Confirmed still getting 100% line coverage

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Feb 18, 2021
@skliper skliper added this to the 7.0.0 milestone Feb 18, 2021
@astrogeco astrogeco added CCB:2021-02-24 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Feb 24, 2021
@astrogeco
Copy link
Contributor

@astrogeco astrogeco changed the base branch from main to integration-candidate March 2, 2021 17:01
@skliper skliper force-pushed the fix1153-logenabled_logic branch from 219a615 to ab4f3fc Compare March 3, 2021 12:34
@skliper skliper force-pushed the fix1153-logenabled_logic branch from ab4f3fc to 693cb5d Compare March 3, 2021 12:48
@skliper
Copy link
Contributor Author

skliper commented Mar 3, 2021

@astrogeco - ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of HK parameter (LogEnabled) in EVS control logic
2 participants