Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #618, Use osal_id_t in RTEMS implementation #619

Merged

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Oct 2, 2020

Describe the contribution

Change use of uint32 for ID to the correct typedef. Also use ObjectIdFromInteger/ObjectIdToInteger where it is intended to
convert these values to integers e.g. for the "name" fields in RTEMS.

Fixes #618

Testing performed
Build and sanity test CFE on RTEMS
Confirm all unit tests working

Expected behavior changes
None

System(s) tested on
RTEMS 4.11.3 / pc686 (QEMU) via Ubuntu 20.04 build host

Additional context
For consistency with all other modules

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Change use of uint32 for ID to the correct typedef.
Use ObjectIdFromInteger/ObjectIdToInteger where it is intended to
convert these values to integers e.g. for the "name" fields in RTEMS.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Oct 2, 2020
@astrogeco
Copy link
Contributor

CCB 2020-10-06 APPROVED

@astrogeco astrogeco added IC-20201013 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 7, 2020
@astrogeco astrogeco changed the base branch from main to integration-candidate October 12, 2020 23:30
@astrogeco astrogeco merged commit 2b6f2d1 into nasa:integration-candidate Oct 12, 2020
@jphickey jphickey deleted the fix-618-rtems-osal-id branch December 3, 2020 17:26
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RTEMS osal to use osal_id_t typedef
3 participants