Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RTEMS osal to use osal_id_t typedef #618

Closed
jphickey opened this issue Oct 2, 2020 · 0 comments · Fixed by #619 or #621
Closed

Update RTEMS osal to use osal_id_t typedef #618

jphickey opened this issue Oct 2, 2020 · 0 comments · Fixed by #619 or #621
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented Oct 2, 2020

Is your feature request related to a problem? Please describe.
While fixing #615 I noticed that the RTEMS OSAL is still using uint32 for its IDs.

Describe the solution you'd like
This should be changed to use the osal_id_t typedef instead.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Oct 2, 2020
jphickey added a commit to jphickey/osal that referenced this issue Oct 2, 2020
@jphickey
Fix nasa#618, Use osal_id_t in RTEMS implementation
39e004f 
Change use of uint32 for ID to the correct typedef.
Use ObjectIdFromInteger/ObjectIdToInteger where it is intended to
convert these values to integers e.g. for the "name" fields in RTEMS.
@jphickey jphickey mentioned this issue Oct 2, 2020
Merged
astrogeco added a commit that referenced this issue Oct 12, 2020
@astrogeco
Merge pull request #619 from jphickey/fix-618-rtems-osal-id
2b6f2d1 
Fix #618, Use osal_id_t in RTEMS implementation
astrogeco added a commit to nasa/cFS that referenced this issue Oct 12, 2020
@astrogeco
Add nasa/osal#618
978abb8
@astrogeco astrogeco mentioned this issue Oct 12, 2020
Merged
@astrogeco astrogeco added this to the 6.0.0 milestone Oct 13, 2020
jphickey added a commit to jphickey/osal that referenced this issue Aug 10, 2022
@jphickey
Fix nasa#618, stubs must not depend on real msgid implementation
8642f8a 
The CFE_SB_GetMsgId/SetMsgId functions, among others, were implemented
as replicas of the actual FSW code.  This creates a dependency on the
actual definition of MsgId used by the mission.

This makes the stub and actual stub.  Stubs not actually
read/write to the message in any way, they just manipulate a
local (stored in the UT framework) out-of-band buffer to hold
the metadata about the message.

This revealed a few other minor issues in test cases where they
were depending on values sitting in globals (fixed).
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#674 from jphickey/fix-618-stub-msgid-dependency
d2c54cc 
Fix nasa#618, stubs must not depend on real msgid implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @astrogeco