Fix #344, Consistent directory entry size limit #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
skliper
force-pushed
the
fix344-dirent-name-size
branch
from
70c3e7f
to
e8a1cfe
Compare
|
Rebased on the OS_FS deprecation commit to resolve conflicts. Also fixed all the coverage test errors from the rebase on master (didn't previously run the coverage tests). Confirmed 100% coverage on filesys. |
|
CCB 20200422 - APPROVED |
skliper
added
CCB - 20200422
CCB:Approved
Changes FileName in os_dirent_t from OS_MAX_PATH_LEN to OS_MAX_FILE_NAME, and moves OS_check_name_length into OS_TranslatePath so it is consistantly applied everywhere. Also fixes the length checks in OS_check_name_length to account for terminating null. Unit tests updated to match new directory name limit. Coverage tests updated to match simplified logic.
skliper
force-pushed
the
fix344-dirent-name-size
branch
from
e8a1cfe
to
3fdd398
Compare
|
@astrogeco try this... resolved conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Changes FileName in os_dirent_t from OS_MAX_PATH_LEN to OS_MAX_FILE_NAME,
and moves OS_check_name_length into OS_TranslatePath so it is
consistantly applied everywhere. Also fixes the length checks in
OS_check_name_length to account for terminating null.
Unit tests updated to match new directory name limit.
Fix #344
Note - since this was merged with the #262 fix, this will also resolve that issue.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Individual directory names now limited to OS_MAX_FILE_NAME
System(s) tested on
Additional context
Note it's based on #421 to avoid conflicts and help with IC merge.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC