Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osfilesys.c mixed return types #118

Closed
skliper opened this issue Sep 30, 2019 · 5 comments
Closed

osfilesys.c mixed return types #118

skliper opened this issue Sep 30, 2019 · 5 comments
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

In osfilesys.c, some functions return OS_SUCCESS (from osapi.h) and some functions return OS_FS_SUCCESS (from osapi-os-filesys.h).
@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 95. Created by abrown4 on 2015-08-19T19:28:20, last modified: 2019-08-14T14:11:46

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by abrown4 on 2015-08-19 20:59:59:

(Identified with vxworks osal code review on branch #45.)

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by abrown4 on 2015-08-24 17:03:38:

Note, these are the same #define numerical value of zero, but we should revisit the idea of mixing return types from different headers in functions from the same "filesystem api".

@skliper skliper removed their assignment Sep 30, 2019
@skliper skliper mentioned this issue Oct 22, 2019
Closed
@skliper
Copy link
Contributor Author

skliper commented Oct 22, 2019

See also #262.

@skliper skliper added enhancement and removed bug labels Oct 22, 2019
@dmknutsen dmknutsen mentioned this issue Apr 17, 2020
Closed
@skliper
Copy link
Contributor Author

skliper commented Dec 2, 2020

This was resolved by 41862fd, which got merged as part of #423. Fixed.

@skliper skliper closed this as completed Dec 2, 2020
@skliper skliper added this to the v5.1.0 milestone Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Bootes
Development

No branches or pull requests
1 participant
@skliper