Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #354, Shell related API separated for optional implementation #418

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 15, 2020

Describe the contribution
Adds a portable OS_ShellOutputToFile_Impl no-shell implementation following the no-network model
Splits posix/rtems/vxworks OS_ShellOutputToFile_Impl into a separate osshell.c (was in osfileapi.c)
Defaults to use the not implemented version (to match certification target)
Added unit test wrapper
Fix #354

Testing performed
Steps taken to test the contribution:

  1. Built for posix with and with not implemented version
  2. CI test with not implemented - https://travis-ci.com/github/skliper/cFS/builds/160380448

NOTE - build for vxworks attempted, but ran into other issues introduced since last check on that system (elf2cfetbl casts missing to match format)

Expected behavior changes
Command to run in shell and output to fill will fail with default (not implemented) setting. Open issue to resolve is nasa/cFE#484

System(s) tested on

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 15, 2020
@skliper skliper added this to the 5.1.0 milestone Apr 15, 2020
@astrogeco
Copy link
Contributor

CCB 20200415 - APPROVED, @jphickey to check RTEMS, will need to be reconciled #285

@skliper
Copy link
Contributor Author

skliper commented Apr 15, 2020

CCB 20200415 - APPROVED, will need rebase prior to merge to IC

Defaults to not include OS_ShellOutputToFile implementation
@skliper
Copy link
Contributor Author

skliper commented Apr 20, 2020

Rebased on master

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB CCB - 20200415 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 22, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 22, 2020 17:11
@astrogeco astrogeco merged commit 592fd3c into nasa:integration-candidate Apr 22, 2020
@skliper skliper deleted the fix354-shell-split branch February 1, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split shell code out to support optional inclusion
2 participants