Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split shell code out to support optional inclusion #354

Closed
skliper opened this issue Jan 21, 2020 · 0 comments · Fixed by #418 or #433
Closed

Split shell code out to support optional inclusion #354

skliper opened this issue Jan 21, 2020 · 0 comments · Fixed by #418 or #433
Assignees
@skliper
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Jan 21, 2020

Is your feature request related to a problem? Please describe.
Execute in shell functionality is undesirable for some security conscious applications.

Describe the solution you'd like
Allow for optional inclusion (like network option?), respond as not implemented when not included.

Describe alternatives you've considered
Discussed security at length, diverse use cases require flexibility for user to decide.

Additional context
POSIX issue found in LGTM

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 5.1.0 milestone Jan 21, 2020
@skliper skliper mentioned this issue Jan 21, 2020
Closed
@skliper skliper self-assigned this Apr 13, 2020
@skliper skliper mentioned this issue Apr 14, 2020
Closed
skliper added a commit to skliper/osal that referenced this issue Apr 14, 2020
@skliper
Fix nasa#354, Split shell API for optional implement
e30a806
skliper added a commit to skliper/osal that referenced this issue Apr 14, 2020
@skliper
Fix nasa#354, Split shell API for optional implement
3fd78d7 
Defaults to not include OS_ShellOutputToFile implementation
@skliper skliper mentioned this issue Apr 15, 2020
Merged
2 tasks
skliper added a commit to skliper/osal that referenced this issue Apr 20, 2020
@skliper
Fix nasa#354, Split shell API for optional implement
1f5bdcb 
Defaults to not include OS_ShellOutputToFile implementation
astrogeco added a commit that referenced this issue Apr 22, 2020
@astrogeco
Merge pull request #418 from skliper/fix354-shell-split
592fd3c 
Fix #354, Shell related API separated for optional implementation
@astrogeco astrogeco mentioned this issue Apr 27, 2020
Merged
@astrogeco astrogeco linked a pull request Apr 27, 2020 that will close this issue
Integration Candidate: 2020-04-15 #433
Merged
astrogeco pushed a commit that referenced this issue May 1, 2020
@skliper
Fix #354, Split shell API for optional implement
962bd96 
Defaults to not include OS_ShellOutputToFile implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
enhancement
Projects
None yet
Milestone
Bootes
1 participant
@skliper