Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate 20191001 #264

Merged
merged 5 commits into from
Oct 2, 2019
Merged

Integration Candidate 20191001 #264

merged 5 commits into from
Oct 2, 2019

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Oct 2, 2019

Describe the contribution
Covers the following pull requests:

Testing performed
Steps taken to test the contribution:

  1. Followed standard build/run steps with permissive mode on cFS development server

Expected behavior changes
Only functional change is OS_TimerSet returns OS_ERROR on 0,0, see pull requests for full details

System(s) tested on:

  • cFS development server
  • Ubuntu 16.04.6 LTS, 4.4.0-164-generic
  • Versions: ic-20191001 bundle (all ic-20191001 branches)

Additional context
NA

Contributor Info
Jacob Hageman - NASA/GSFC

Community contributors
CLA on file

jphickey and others added 5 commits September 18, 2019 16:13
Qualify all pointers referring to string literals as `const`
Eliminate unused local variables
Add missing local function prototypes.
Update all block comments for OSAL functions to follow a
consistent style and ensure correctness of the descriptions.

- All documentation covering the specific details, inputs/outputs
and return values should be on the function _declaration_, not the
definition.

- The definition should also contain a block comment for visual
distinction in the source file, but should be brief and refer
back to the prototype/declaration for detail.  Any detail information
that was indicated only with the definition is moved to the
declaration.

- Add doxygen tags/markup to external/public API block comments
and expand the descriptions of these functions where needed.

- Add block comments to the internal API prototypes, but _not_
as doxygen tags/markup.  Note these functions are internal use,
not part of the public API, and are not necessarily intended
to be stable across OSAL releases like the public API is.

- Removed stray prototypes for functions where there was no
actual definition/implementation.
Reviewed and approved at 2019-09-25 CCB
@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Oct 2, 2019
@skliper skliper merged commit 4f6afbe into master Oct 2, 2019
@skliper skliper deleted the ic-20191001 branch October 8, 2019 14:48
@skliper skliper added this to the 5.1.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants