Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return OS_ERROR if OS_TimerSet is called with both parameters as zero #11

Closed
skliper opened this issue Sep 13, 2019 · 3 comments · Fixed by #19
Closed

Return OS_ERROR if OS_TimerSet is called with both parameters as zero #11

skliper opened this issue Sep 13, 2019 · 3 comments · Fixed by #19
Assignees
@avan989
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Sep 13, 2019

Is your feature request related to a problem? Please describe.
Related to the discussion in #9

Describe the solution you'd like
See title, as described in #9 (comment)

Describe alternatives you've considered
See #9 comment thread

Additional context
None

Requester Info
Jacob Hageman/NASA-GSFC
@avan989
Copy link
Contributor

avan989 commented Sep 16, 2019

I'll do this.

@avan989
Copy link
Contributor

avan989 commented Sep 17, 2019

I need a little more clarification on this. There are 3 files that contains OS_TimerSet. Is the fix asking to change in all 3 (psix, rtems, vxworks6) or just in rtems?

@jphickey
Copy link
Contributor

Be sure to do a "pull" first. The merge from rc-5.0.0 happened recently. You should find just one implementation of this function in the "shared" directory.

skliper added a commit that referenced this issue Oct 1, 2019
@skliper
Merge pull request #19 from avan989/OS_ERROR
58cf977 
Fix #11, Update OS_TimerSet to return OS_ERROR
skliper added a commit that referenced this issue Oct 1, 2019
@skliper
CCB 2019-09-25: Merge #10, #11, #15, #17
4f6afbe 
Reviewed and approved at 2019-09-25 CCB
@skliper skliper closed this as completed in ef6863f Oct 2, 2019
@skliper skliper added this to the 5.1.0 milestone Oct 2, 2019
@avan989 avan989 mentioned this issue May 13, 2020
Merged
@skliper skliper linked a pull request May 13, 2020 that will close this issue
Fix #11, Update OS_TimerSet to return OS_ERROR #19
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avan989 avan989

Labels
enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #11, Update OS_TimerSet to return OS_ERROR
4 participants
@jphickey @avan989 @skliper @astrogeco