-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1214, Resolve UT uninitialized variable warnings #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
label
Feb 10, 2022
astrogeco
added
CCB:Approved
Indicates code review and approval by community CCB
and removed
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
labels
Feb 16, 2022
CCB:2022-02-16 APPROVED |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 23, 2022
2 tasks
astrogeco
added a commit
that referenced
this pull request
Feb 25, 2022
Part of IC:Caelum+dev4, nasa/cFS#432 **Includes** PR #1215 - Resolve UT uninitialized variable warnings PR #1219 - Add ut_assert to doxygen and fix warnings PR #1223 - Protect if OS_FDGetInfo called on socket
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 25, 2022
**Combines** - nasa/cFE#2061, v7.0.0-rc4+dev80 - nasa/osal#1226, v6.0.0-rc4+dev42 - nasa/PSP#326, v1.6.0-rc4+dev14 *Apps* - ci_lab v2.5.0-rc4+dev10 - sample_app v1.3.0-rc4+dev9 - sch_lab v2.5.0-rc4+dev16 - to_lab v2.5.0-rc4+dev9 *Libs* - sample_lib v1.3.0-rc4+dev9 *Tools* - cFS-GroundSystem v3.0.0-rc4+dev12 - elf2cfetbl v3.3.0-rc4+dev11 - tblCRCTool v1.3.0-rc4+dev7 **Includes** - nasa/cFE#2048, Add CFE_ES_CreateChildTask default handler - nasa/osal#1215, Resolve UT uninitialized variable warnings - nasa/osal#1219, Add ut_assert to doxygen and fix warnings - nasa/osal#1223, protect if OS_FDGetInfo called on socket - nasa/cFE#2056, Missing SB include for v2 msgid - nasa/cFE#2052, Resolve doxygen doc warnings and enforce in CI *Apply Header Guard Standard* - nasa/PSP#322 - nasa/ci_lab#103 - nasa/to_lab#114 - nasa/sch_lab#107 - nasa/sample_lib#74 - nasa/elf2cfetbl#100 - nasa/cFS-GroundSystem#205 *Remove explicit filename doxygen comments* - nasa/cFE#2050 - nasa/osal#1217 - nasa/PSP#324 - nasa/sample_lib#76 - nasa/tblCRCTool#62 - nasa/elf2cfetbl#102
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 25, 2022
**Combines** - nasa/cFE#2061, v7.0.0-rc4+dev80 - nasa/osal#1226, v6.0.0-rc4+dev42 - nasa/PSP#326, v1.6.0-rc4+dev14 *Apps* - ci_lab v2.5.0-rc4+dev10 - sample_app v1.3.0-rc4+dev9 - sch_lab v2.5.0-rc4+dev16 - to_lab v2.5.0-rc4+dev9 *Libs* - sample_lib v1.3.0-rc4+dev9 *Tools* - cFS-GroundSystem v3.0.0-rc4+dev12 - elf2cfetbl v3.3.0-rc4+dev11 - tblCRCTool v1.3.0-rc4+dev7 **Includes** - nasa/cFE#2048, Add CFE_ES_CreateChildTask default handler - nasa/osal#1215, Resolve UT uninitialized variable warnings - nasa/osal#1219, Add ut_assert to doxygen and fix warnings - nasa/osal#1223, protect if OS_FDGetInfo called on socket - nasa/cFE#2056, Missing SB include for v2 msgid - nasa/cFE#2052, Resolve doxygen doc warnings and enforce in CI *Apply Header Guard Standard* - nasa/PSP#322 - nasa/ci_lab#103 - nasa/to_lab#114 - nasa/sch_lab#107 - nasa/sample_lib#74 - nasa/elf2cfetbl#100 - nasa/cFS-GroundSystem#205 *Remove explicit filename doxygen comments* - nasa/cFE#2050 - nasa/osal#1217 - nasa/PSP#324 - nasa/sample_lib#76 - nasa/tblCRCTool#62 - nasa/elf2cfetbl#102
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 25, 2022
**Combines** - nasa/cFE#2061, v7.0.0-rc4+dev80 - nasa/osal#1226, v6.0.0-rc4+dev42 - nasa/PSP#326, v1.6.0-rc4+dev14 *Apps* - ci_lab v2.5.0-rc4+dev10 - sample_app v1.3.0-rc4+dev9 - sch_lab v2.5.0-rc4+dev16 - to_lab v2.5.0-rc4+dev9 *Libs* - sample_lib v1.3.0-rc4+dev9 *Tools* - cFS-GroundSystem v3.0.0-rc4+dev12 - elf2cfetbl v3.3.0-rc4+dev11 - tblCRCTool v1.3.0-rc4+dev7 **Includes** - nasa/cFE#2048, Add CFE_ES_CreateChildTask default handler - nasa/osal#1215, Resolve UT uninitialized variable warnings - nasa/osal#1219, Add ut_assert to doxygen and fix warnings - nasa/osal#1223, protect if OS_FDGetInfo called on socket - nasa/cFE#2056, Missing SB include for v2 msgid - nasa/cFE#2052, Resolve doxygen doc warnings and enforce in CI *Apply Header Guard Standard* - nasa/PSP#322 - nasa/ci_lab#103 - nasa/to_lab#114 - nasa/sch_lab#107 - nasa/sample_lib#74 - nasa/elf2cfetbl#100 - nasa/cFS-GroundSystem#205 *Remove explicit filename doxygen comments* - nasa/cFE#2050 - nasa/osal#1217 - nasa/PSP#324 - nasa/sample_lib#76 - nasa/tblCRCTool#62 - nasa/elf2cfetbl#102 Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]>
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Explicit task registration is no longer necessary, since all required actions can be done before invoking the entry point. This moves the invocation of CFE_PSP_AttachExceptions() from the registration function to the pre-entry function, this was the only remaining action in task registration. All references to task registration in code, docs, and tests are removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Testing performed
Built 32-bit and ran unit tests in valgrind, warnings squashed
Expected behavior changes
No more uninit variable warnings
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC