Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing handler for OS_SocketAddrGetPort_Impl causing uninitialized variable UT warnings #1214

Closed
skliper opened this issue Feb 10, 2022 · 0 comments · Fixed by #1215 or #1226
Closed

Missing handler for OS_SocketAddrGetPort_Impl causing uninitialized variable UT warnings #1214

skliper opened this issue Feb 10, 2022 · 0 comments · Fixed by #1215 or #1226
Assignees
@skliper
Labels
draco-rc1 unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Feb 10, 2022

Is your feature request related to a problem? Please describe.
Unit under test call to OS_SocketAddrGetPort_Impl doesn't set port.

Describe the solution you'd like
Handler should set the port on success (at minimum) to avoid uninitialized variables in unit tests

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Feb 10, 2022
@skliper skliper added this to the Draco milestone Feb 10, 2022
@skliper skliper self-assigned this Feb 10, 2022
skliper added a commit to skliper/osal that referenced this issue Feb 10, 2022
@skliper
Fix nasa#1214, Resolve UT uninitialized variable warnings
49ca8be
@skliper skliper mentioned this issue Feb 10, 2022
Merged
astrogeco added a commit that referenced this issue Feb 23, 2022
@astrogeco
Merge pull request #1215 from skliper/fix1214-uninit_ut_var
603dc13 
Fix #1214, Resolve UT uninitialized variable warnings
@astrogeco astrogeco mentioned this issue Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
draco-rc1 unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Draco
1 participant
@skliper