Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test status code discrepancies in osapi-timer.h #1023

Closed
16 of 26 tasks
jphickey opened this issue May 12, 2021 · 0 comments · Fixed by #1053 or #1058
Closed
16 of 26 tasks

Unit test status code discrepancies in osapi-timer.h #1023

jphickey opened this issue May 12, 2021 · 0 comments · Fixed by #1053 or #1058
Assignees
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The unit tests and API documentation should match, where all status codes in the API documentation are tested in a unit test, and likewise all codes being tested for are documented in the API.

Describe the solution you'd like
Resolve the following mismatches:

File src/os/inc/osapi-timer.h, function OS_TimerCreate():

  • OK: OS_ERR_NAME_TAKEN
  • OK: OS_ERR_NAME_TOO_LONG
  • OK: OS_ERR_NO_FREE_IDS
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS
  • ONLY IN DOXY: OS_TIMER_ERR_INVALID_ARGS
  • ONLY IN DOXY: OS_TIMER_ERR_UNAVAILABLE

File src/os/inc/osapi-timer.h, function OS_TimerAdd():

File src/os/inc/osapi-timer.h, function OS_TimerSet():

  • ONLY IN DOXY: OS_ERROR
  • ONLY IN DOXY: OS_ERR_INCORRECT_OBJ_STATE
  • OK: OS_ERR_INVALID_ID
  • OK: OS_SUCCESS
  • ONLY IN DOXY: OS_TIMER_ERR_INTERNAL
  • ONLY IN DOXY: OS_TIMER_ERR_INVALID_ARGS

File src/os/inc/osapi-timer.h, function OS_TimerDelete():

  • ONLY IN DOXY: OS_ERR_INCORRECT_OBJ_STATE
  • OK: OS_ERR_INVALID_ID
  • OK: OS_SUCCESS
  • ONLY IN DOXY: OS_TIMER_ERR_INTERNAL

File src/os/inc/osapi-timer.h, function OS_TimerGetIdByName():

  • ONLY IN DOXY: OS_ERR_INCORRECT_OBJ_STATE
  • OK: OS_ERR_NAME_NOT_FOUND
  • OK: OS_ERR_NAME_TOO_LONG
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

File src/os/inc/osapi-timer.h, function OS_TimerGetInfo():

  • ONLY IN DOXY: OS_ERR_INCORRECT_OBJ_STATE
  • OK: OS_ERR_INVALID_ID
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

Additional context
Originally noted in #331, split into separate work items.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label May 12, 2021
@skliper skliper added this to the 6.0.0 milestone May 12, 2021
@jphickey jphickey self-assigned this May 24, 2021
jphickey added a commit to jphickey/osal that referenced this issue May 25, 2021
Ensures correlation between the test cases and documented return
values for the OSAL timer API.
jphickey added a commit to jphickey/osal that referenced this issue May 26, 2021
Ensures correlation between the test cases and documented return
values for the OSAL timer API.
jphickey added a commit to jphickey/osal that referenced this issue May 26, 2021
Ensures correlation between the test cases and documented return
values for the OSAL timer API.
astrogeco added a commit that referenced this issue Jun 1, 2021
Fix #1023, resolve discrepancies between timer API and unit tests
pepepr08 pushed a commit to pepepr08/osal that referenced this issue Jun 9, 2021
Ensures correlation between the test cases and documented return
values for the OSAL timer API.
jphickey added a commit to jphickey/osal that referenced this issue Aug 10, 2022
The type of this should be CFE_ES_ResourceID_t, not uint32
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
2 participants