Fix nasa#1023, resolve descrepancies between timer API and unit tests

Ensures correlation between the test cases and documented return
values for the OSAL timer API.

src/os/inc/osapi-timer.h

@@ -61,31 +61,30 @@ typedef struct
  * which is created and deleted with the timer object itself.  The internal time base
  * is configured for an OS simulated timer tick at the same interval as the timer.
  *
+ * The callback function should be declared as follows:
+ *
+ *     <tt> void timer_callback(osal_id_t timer_id); </tt>
+ *
+ * The timer_id is passed in to the function by the OSAL
+ *
  * @note clock_accuracy comes from the underlying OS tick value.  The nearest integer
  *       microsecond value is returned, so may not be exact.
  *
- * @warning Depending on the OS, the callback_ptr function may be similar to an
- *          interrupt service routine. Calls that cause the code to block or require
- *          an application context (like sending events) are generally not supported.
- *
- * @param[out]  timer_id        The non-zero resource ID of the timer object
- * @param[in]   timer_name      Name of the timer object
+ * @param[out]  timer_id        Will be set to the non-zero resource ID of the timer object @nonnull
+ * @param[in]   timer_name      Name of the timer object @nonnull
  * @param[out]  clock_accuracy  Expected precision of the timer, in microseconds. This
  *                              is the underlying tick value rounded to the nearest
- *                              microsecond integer.
- * @param[in]   callback_ptr    The function pointer of the timer callback or ISR that
- *                              will be called by the timer. The user’s function is
- *                              declared as follows: <tt> void timer_callback(uint32 timer_id) </tt>
- *                              Where the timer_id is passed in to the function by the OSAL
+ *                              microsecond integer. @nonnull
+ * @param[in]   callback_ptr    The function pointer of the timer callback @nonnull.
  *
  * @return Execution status, see @ref OSReturnCodes
  * @retval #OS_SUCCESS @copybrief OS_SUCCESS
  * @retval #OS_INVALID_POINTER if any parameters are NULL
  * @retval #OS_ERR_NAME_TOO_LONG name length including null terminator greater than #OS_MAX_API_NAME
  * @retval #OS_ERR_NAME_TAKEN if the name is already in use by another timer.
  * @retval #OS_ERR_NO_FREE_IDS if all of the timers are already allocated.
- * @retval #OS_TIMER_ERR_INVALID_ARGS if the callback pointer is zero.
- * @retval #OS_TIMER_ERR_UNAVAILABLE if the timer cannot be created.
+ * @retval #OS_ERR_INCORRECT_OBJ_STATE if invoked from a timer context
+ * @retval #OS_TIMER_ERR_INTERNAL if there was an error programming the OS timer @covtest
  */
 int32 OS_TimerCreate(osal_id_t *timer_id, const char *timer_name, uint32 *clock_accuracy,
                      OS_TimerCallback_t callback_ptr);
@@ -106,17 +105,28 @@ int32 OS_TimerCreate(osal_id_t *timer_id, const char *timer_name, uint32 *clock_
  * allowing a single opaque argument to be passed to the callback routine.
  * The OSAL implementation does not use this parameter, and may be set NULL.
  *
- * @warning Depending on the OS, the callback_ptr function may be similar to an
- *          interrupt service routine. Calls that cause the code to block or require
- *          an application context (like sending events) are generally not supported.
+ * The callback function for this method should be declared as follows:
+ *
+ *      <tt>void timer_callback(osal_id_t object_id, void *arg);</tt>
+ *
+ * The timer_id is passed in to the function by the OSAL, and the arg parameter
+ * is passed through from the callback_arg argument on this call.
  *
- * @param[out]  timer_id        The non-zero resource ID of the timer object
- * @param[in]   timer_name      Name of the timer object
+ * @param[out]  timer_id        Will be set to the non-zero resource ID of the timer object @nonnull
+ * @param[in]   timer_name      Name of the timer object @nonnull
  * @param[in]   timebase_id     The time base resource to use as a reference
- * @param[in]   callback_ptr    Application-provided function to invoke
- * @param[in]   callback_arg    Opaque argument to pass to callback function
+ * @param[in]   callback_ptr    Application-provided function to invoke @nonnull
+ * @param[in]   callback_arg    Opaque argument to pass to callback function, may be NULL
  *
  * @return Execution status, see @ref OSReturnCodes
+ * @retval #OS_SUCCESS @copybrief OS_SUCCESS
+ * @retval #OS_INVALID_POINTER if any parameters are NULL
+ * @retval #OS_ERR_INVALID_ID if the timebase_id parameter is not valid
+ * @retval #OS_ERR_NAME_TOO_LONG name length including null terminator greater than #OS_MAX_API_NAME
+ * @retval #OS_ERR_NAME_TAKEN if the name is already in use by another timer.
+ * @retval #OS_ERR_NO_FREE_IDS if all of the timers are already allocated.
+ * @retval #OS_ERR_INCORRECT_OBJ_STATE if invoked from a timer context
+ * @retval #OS_TIMER_ERR_INTERNAL if there was an error programming the OS timer @covtest
  */
 int32 OS_TimerAdd(osal_id_t *timer_id, const char *timer_name, osal_id_t timebase_id, OS_ArgCallback_t callback_ptr,
                   void *callback_arg);
@@ -149,10 +159,9 @@ int32 OS_TimerAdd(osal_id_t *timer_id, const char *timer_name, osal_id_t timebas
  * @return Execution status, see @ref OSReturnCodes
  * @retval #OS_SUCCESS @copybrief OS_SUCCESS
  * @retval #OS_ERR_INVALID_ID if the timer_id is not valid.
- * @retval #OS_TIMER_ERR_INTERNAL if there was an error programming the OS timer.
- * @retval #OS_ERROR if both start time and interval time are zero.
+ * @retval #OS_TIMER_ERR_INTERNAL if there was an error programming the OS timer @covtest
  * @retval #OS_ERR_INCORRECT_OBJ_STATE if called from timer/timebase context
- * @retval #OS_TIMER_ERR_INVALID_ARGS if the start_time or interval_time is out of range
+ * @retval #OS_TIMER_ERR_INVALID_ARGS if the start_time or interval_time is out of range, or both 0
  */
 int32 OS_TimerSet(osal_id_t timer_id, uint32 start_time, uint32 interval_time);
 
@@ -168,7 +177,7 @@ int32 OS_TimerSet(osal_id_t timer_id, uint32 start_time, uint32 interval_time);
  * @return Execution status, see @ref OSReturnCodes
  * @retval #OS_SUCCESS @copybrief OS_SUCCESS
  * @retval #OS_ERR_INVALID_ID if the timer_id is invalid.
- * @retval #OS_TIMER_ERR_INTERNAL if there was a problem deleting the timer in the host OS.
+ * @retval #OS_TIMER_ERR_INTERNAL if there was a problem deleting the timer in the host OS @covtest
  * @retval #OS_ERR_INCORRECT_OBJ_STATE if called from timer/timebase context
  */
 int32 OS_TimerDelete(osal_id_t timer_id);
@@ -179,8 +188,8 @@ int32 OS_TimerDelete(osal_id_t timer_id);
  *
  * Outputs the ID associated with the given timer, if it exists.
  *
- * @param[out] timer_id      The timer ID corresponding to the name
- * @param[in]  timer_name    The timer name to find
+ * @param[out] timer_id      Will be set to the timer ID corresponding to the name @nonnull
+ * @param[in]  timer_name    The timer name to find @nonnull
  *
  * @return Execution status, see @ref OSReturnCodes
  * @retval #OS_SUCCESS @copybrief OS_SUCCESS
@@ -199,7 +208,7 @@ int32 OS_TimerGetIdByName(osal_id_t *timer_id, const char *timer_name);
  * information known about that timer into a structure pointer to by timer_prop.
  *
  * @param[in]  timer_id      The timer ID to operate on
- * @param[out] timer_prop    Buffer containing timer properties
+ * @param[out] timer_prop    Buffer containing timer properties @nonnull
  *                           - creator: the OS task ID of the task that created this timer
  *                           - name: the string name of the timer
  *                           - start_time: the start time in microseconds, if any

src/os/shared/src/osapi-time.c

@@ -315,7 +315,7 @@ int32 OS_TimerSet(osal_id_t timer_id, uint32 start_time, uint32 interval_time)
 
     ARGCHECK(start_time < (UINT32_MAX / 2), OS_TIMER_ERR_INVALID_ARGS);
     ARGCHECK(interval_time < (UINT32_MAX / 2), OS_TIMER_ERR_INVALID_ARGS);
-    ARGCHECK(start_time != 0 || interval_time != 0, OS_ERROR);
+    ARGCHECK(start_time != 0 || interval_time != 0, OS_TIMER_ERR_INVALID_ARGS);
 
     /*
      * Check our context.  Not allowed to use the timer API from a timer callback.

src/tests/timer-add-api-test/timer-add-api-test.c

@@ -73,7 +73,8 @@ void TestTimerAddApi(void)
     osal_id_t time_base_id;
     int       i = 0;
     int32     TimerStatus[NUMBER_OF_TIMERS];
-    osal_id_t TimerID[NUMBER_OF_TIMERS];
+    osal_id_t TimerID[OS_MAX_TIMERS];
+    char      temp_name[OS_MAX_API_NAME + 5];
     char      TimerName[NUMBER_OF_TIMERS][20] = {"TIMER1", "TIMER2", "TIMER3", "TIMER4"};
     uint32    microsecs;
 
@@ -87,11 +88,28 @@ void TestTimerAddApi(void)
     expected    = OS_SUCCESS;
     UtAssert_True(tbs_ret_val == expected, "OS_TimeBaseSet() (%ld) == OS_SUCCESS", (long)tbs_ret_val);
 
+    memset(temp_name, 'x', sizeof(temp_name) - 1);
+    temp_name[sizeof(temp_name) - 1] = 0;
+    UtAssert_INT32_EQ(OS_TimerAdd(&timer_id, temp_name, time_base_id, &null_func, NULL), OS_ERR_NAME_TOO_LONG);
+
+    for (i = 0; i < OS_MAX_TIMERS; i++)
+    {
+        snprintf(temp_name, sizeof(temp_name), "Timer%d", i);
+        UtAssert_INT32_EQ(OS_TimerAdd(&TimerID[i], temp_name, time_base_id, &null_func, NULL), OS_SUCCESS);
+        UtPrintf("Timer %d Created ID=%lx", i, OS_ObjectIdToInteger(TimerID[i]));
+    }
+
+    UtAssert_INT32_EQ(OS_TimerAdd(&timer_id, "TooMany", time_base_id, &null_func, NULL), OS_ERR_NO_FREE_IDS);
+    for (i = 0; i < OS_MAX_TIMERS; i++)
+    {
+        UtAssert_INT32_EQ(OS_TimerDelete(TimerID[i]), OS_SUCCESS);
+    }
+
     for (i = 0; i < NUMBER_OF_TIMERS; i++)
     {
-        TimerStatus[i] = OS_TimerAdd(&TimerID[i], TimerName[i], time_base_id, &counter_func, &timer_counter[i]);
-        UtAssert_True(TimerStatus[i] == OS_SUCCESS, "Timer %d Created RC=%d ID=%lx", i, (int)TimerStatus[i],
-                      OS_ObjectIdToInteger(TimerID[i]));
+        UtAssert_INT32_EQ(OS_TimerAdd(&TimerID[i], TimerName[i], time_base_id, &counter_func, &timer_counter[i]),
+                          OS_SUCCESS);
+        UtPrintf("Timer %d Created ID=%lx", i, OS_ObjectIdToInteger(TimerID[i]));
     }
 
     /* Sample the clock now, before starting any timer */

src/unit-test-coverage/shared/src/coveragetest-time.c

@@ -170,9 +170,9 @@ void Test_OS_TimerSet(void)
      * Test Case For:
      * int32 OS_TimerSet(uint32 timer_id, uint32 start_time, uint32 interval_time)
      */
-    int32 expected = OS_ERROR;
+    int32 expected = OS_TIMER_ERR_INVALID_ARGS;
     int32 actual   = OS_TimerSet(UT_OBJID_1, 0, 0);
-    UtAssert_True(actual == expected, "OS_TimerSet() (%ld) == OS_ERROR", (long)actual);
+    UtAssert_True(actual == expected, "OS_TimerSet() (%ld) == OS_TIMER_ERR_INVALID_ARGS", (long)actual);
 
     expected = OS_SUCCESS;
     actual   = OS_TimerSet(UT_OBJID_1, 0, 1);

src/unit-tests/ostimer-test/ut_ostimer_test.c

@@ -203,6 +203,7 @@ void UtTest_Setup(void)
     UtTest_Add(UT_os_timergetidbyname_test, UT_os_setup_timergetidbyname_test, NULL, "OS_TimerGetIdByName");
     UtTest_Add(UT_os_timergetinfo_test, UT_os_setup_timergetinfo_test, NULL, "OS_TimerGetInfo");
     UtTest_Add(UT_os_timerset_test, UT_os_setup_timerset_test, NULL, "OS_TimerSet");
+    UtTest_Add(UT_os_timerreconf_test, NULL, NULL, "TimerReconfig");
 }
 
 /*================================================================================*

src/unit-tests/ostimer-test/ut_ostimer_test.h

@@ -33,12 +33,13 @@
 **--------------------------------------------------------------------------------*/
 
 #include "ut_os_support.h"
-#include "ut_ostimer_timerio_test.h"
 
 /*--------------------------------------------------------------------------------*
 ** Macros
 **--------------------------------------------------------------------------------*/
 
+#define UT_OS_TIMER_LIST_LEN (OS_MAX_TIMERS + 10)
+
 /*--------------------------------------------------------------------------------*
 ** Data types
 **--------------------------------------------------------------------------------*/
@@ -47,6 +48,21 @@
 ** External global variables
 **--------------------------------------------------------------------------------*/
 
+extern const char *g_timerNames[UT_OS_TIMER_LIST_LEN];
+extern char        g_longTimerName[UT_OS_NAME_BUFF_SIZE];
+
+extern uint32    g_cbLoopCntMax;
+extern uint32    g_toleranceVal;
+extern uint32    g_timerFirst;
+extern int32     g_status;
+extern osal_id_t g_timerId;
+
+extern int32 TimerCreateRc;
+extern int32 TimerDeleteRc;
+extern int32 TimerSetRc;
+extern int32 TimerGetByNameRc;
+extern int32 TimerGetInfoRc;
+
 /*--------------------------------------------------------------------------------*
 ** Global variables
 **--------------------------------------------------------------------------------*/
@@ -55,6 +71,15 @@
 ** Function prototypes
 **--------------------------------------------------------------------------------*/
 
+void UT_os_timercallback(osal_id_t timerId);
+
+void UT_os_timercreate_test(void);
+void UT_os_timerdelete_test(void);
+void UT_os_timerset_test(void);
+void UT_os_timerreconf_test(void);
+void UT_os_timergetidbyname_test(void);
+void UT_os_timergetinfo_test(void);
+
 /*--------------------------------------------------------------------------------*/
 
 #endif /* UT_OSTIMER_TEST_H */