Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test status code discrepancies in osapi-file.h #1013

Closed
45 of 72 tasks
jphickey opened this issue May 12, 2021 · 0 comments · Fixed by #1056 or #1076
Closed
45 of 72 tasks

Unit test status code discrepancies in osapi-file.h #1013

jphickey opened this issue May 12, 2021 · 0 comments · Fixed by #1056 or #1076
Assignees
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The unit tests and API documentation should match, where all status codes in the API documentation are tested in a unit test, and likewise all codes being tested for are documented in the API.

Describe the solution you'd like
Resolve the following mismatches:

File src/os/inc/osapi-file.h, function OS_OpenCreate():

  • OK: OS_ERROR
  • ONLY IN TEST: OS_ERR_NO_FREE_IDS
  • ONLY IN TEST: OS_FS_ERR_NAME_TOO_LONG
  • ONLY IN TEST: OS_FS_ERR_PATH_INVALID
  • ONLY IN TEST: OS_FS_ERR_PATH_TOO_LONG
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_close():

  • ONLY IN DOXY: OS_ERROR
  • OK: OS_ERR_INVALID_ID
  • OK: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_read():

  • ONLY IN DOXY: 0
  • ONLY IN DOXY: OS_ERROR
  • OK: OS_ERR_INVALID_ID
  • OK: OS_INVALID_POINTER

File src/os/inc/osapi-file.h, function OS_write():

  • ONLY IN DOXY: 0
  • ONLY IN DOXY: OS_ERROR
  • OK: OS_ERR_INVALID_ID
  • OK: OS_INVALID_POINTER

File src/os/inc/osapi-file.h, function OS_TimedRead():

  • ONLY IN DOXY: 0
  • ONLY IN DOXY: OS_ERROR_TIMEOUT
  • ONLY IN DOXY: OS_ERR_INVALID_ID
  • ONLY IN DOXY: OS_ERR_INVALID_SIZE
  • ONLY IN DOXY: OS_INVALID_POINTER

File src/os/inc/osapi-file.h, function OS_TimedWrite():

  • ONLY IN DOXY: 0
  • ONLY IN DOXY: OS_ERROR_TIMEOUT
  • ONLY IN DOXY: OS_ERR_INVALID_ID
  • ONLY IN DOXY: OS_ERR_INVALID_SIZE
  • ONLY IN DOXY: OS_INVALID_POINTER

File src/os/inc/osapi-file.h, function OS_chmod():
NONE - no specific retvals in API, and no checks in test (possibly need to add).

File src/os/inc/osapi-file.h, function OS_stat():

  • OK: OS_ERROR
  • ONLY IN DOXY: OS_FS_ERR_NAME_TOO_LONG
  • OK: OS_FS_ERR_PATH_INVALID
  • OK: OS_FS_ERR_PATH_TOO_LONG
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_lseek():

  • OK: OS_ERROR
  • OK: OS_ERR_INVALID_ID

File src/os/inc/osapi-file.h, function OS_remove():

  • ONLY IN DOXY: OS_ERROR
  • OK: OS_FS_ERR_NAME_TOO_LONG
  • OK: OS_FS_ERR_PATH_INVALID
  • OK: OS_FS_ERR_PATH_TOO_LONG
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_rename():

  • ONLY IN DOXY: OS_ERROR
  • OK: OS_FS_ERR_NAME_TOO_LONG
  • OK: OS_FS_ERR_PATH_INVALID
  • OK: OS_FS_ERR_PATH_TOO_LONG
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_cp():

  • ONLY IN DOXY: OS_ERROR
  • OK: OS_FS_ERR_NAME_TOO_LONG
  • OK: OS_FS_ERR_PATH_INVALID
  • OK: OS_FS_ERR_PATH_TOO_LONG
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_mv():

  • ONLY IN DOXY: OS_ERROR
  • OK: OS_FS_ERR_NAME_TOO_LONG
  • OK: OS_FS_ERR_PATH_INVALID
  • OK: OS_FS_ERR_PATH_TOO_LONG
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_FDGetInfo():

  • OK: OS_ERR_INVALID_ID
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_FileOpenCheck():

  • OK: OS_ERROR
  • OK: OS_INVALID_POINTER
  • ONLY IN TEST: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_CloseAllFiles():

  • ONLY IN DOXY: OS_ERROR
  • OK: OS_SUCCESS

File src/os/inc/osapi-file.h, function OS_CloseFileByName():

  • ONLY IN DOXY: OS_ERROR
  • OK: OS_FS_ERR_PATH_INVALID
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

Additional context
Originally noted in #331, split into separate work items.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label May 12, 2021
@skliper skliper added this to the 6.0.0 milestone May 12, 2021
@jphickey jphickey self-assigned this May 27, 2021
jphickey added a commit to jphickey/osal that referenced this issue May 27, 2021
Ensures correlation between the test cases and documented return
values for the OSAL file API.
astrogeco added a commit that referenced this issue Jun 10, 2021
Fix #1013, resolve discrepancies between file API and unit tests
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
2 participants