Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test status code discrepancies in osapi-dir.h #1012

Closed
18 tasks done
jphickey opened this issue May 12, 2021 · 0 comments · Fixed by #1045 or #1058
Closed
18 tasks done

Unit test status code discrepancies in osapi-dir.h #1012

jphickey opened this issue May 12, 2021 · 0 comments · Fixed by #1045 or #1058
Assignees
@jphickey
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented May 12, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
The unit tests and API documentation should match, where all status codes in the API documentation are tested in a unit test, and likewise all codes being tested for are documented in the API.

Describe the solution you'd like
Resolve the following mismatches:

File src/os/inc/osapi-dir.h, function OS_DirectoryOpen():

  • ONLY IN TEST: OS_FS_ERR_PATH_INVALID
  • ONLY IN TEST: OS_FS_ERR_PATH_TOO_LONG
  • OK: OS_INVALID_POINTER
  • ONLY IN TEST: OS_SUCCESS

File src/os/inc/osapi-dir.h, function OS_DirectoryClose():

  • ONLY IN TEST: OS_SUCCESS

File src/os/inc/osapi-dir.h, function OS_DirectoryRewind():

  • ONLY IN TEST: OS_SUCCESS

File src/os/inc/osapi-dir.h, function OS_DirectoryRead():

  • ONLY IN TEST: OS_ERR_INVALID_ID
  • OK: OS_INVALID_POINTER

File src/os/inc/osapi-dir.h, function OS_mkdir():

  • ONLY IN DOXY: OS_ERROR
  • OK: OS_FS_ERR_PATH_INVALID
  • OK: OS_FS_ERR_PATH_TOO_LONG
  • OK: OS_INVALID_POINTER
  • ONLY IN DOXY: OS_SUCCESS

File src/os/inc/osapi-dir.h, function OS_rmdir():

  • OK: OS_ERROR
  • OK: OS_FS_ERR_PATH_INVALID
  • OK: OS_FS_ERR_PATH_TOO_LONG
  • OK: OS_INVALID_POINTER
  • OK: OS_SUCCESS

Additional context
Originally noted in #331, split into separate work items.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label May 12, 2021
@skliper skliper added this to the 6.0.0 milestone May 12, 2021
@jphickey jphickey self-assigned this May 21, 2021
jphickey added a commit to jphickey/osal that referenced this issue May 21, 2021
@jphickey
Fix nasa#1012, resolve descrepancies between dir API and unit tests
9a13a5c 
Ensures correlation between the unit-tests and documented return
values for the OSAL directory API.
@jphickey jphickey mentioned this issue May 21, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue May 25, 2021
@jphickey
Fix nasa#1012, resolve descrepancies between dir API and unit tests
5bd645c 
Ensures correlation between the unit-tests and documented return
values for the OSAL directory API.
jphickey added a commit to jphickey/osal that referenced this issue May 26, 2021
@jphickey
Fix nasa#1012, resolve discrepancies between dir API and unit tests
92e56e6 
Ensures correlation between the unit-tests and documented return
values for the OSAL directory API.
@astrogeco astrogeco mentioned this issue Jun 1, 2021
Merged
astrogeco added a commit that referenced this issue Jun 1, 2021
@astrogeco
Merge pull request #1045 from jphickey/fix-1012-dir-api-retcodes
d2837bf 
Fix #1012, resolve discrepancies between dir API and unit tests
pepepr08 pushed a commit to pepepr08/osal that referenced this issue Jun 9, 2021
@jphickey @pepepr08
Fix nasa#1012, resolve discrepancies between dir API and unit tests
e9884ff 
Ensures correlation between the unit-tests and documented return
values for the OSAL directory API.
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#1012, Include cfe_private.h in stubs
d5d7d86
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1013 from skliper/fix1012-priv-inc-stub
c6b2c86 
Fix nasa#1012, Include cfe_private.h in stubs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper