-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Center Confirmation Dialog Texts #7492
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1d055ad
Make overlay messages centered
rukmini-bose 11990f0
Fix changes so that only dialogs and not forms are affected
rukmini-bose 864ba34
Fix buttons such that they are right-aligned
rukmini-bose 88146a9
Merge branch 'master' into confirmation-dialog-mobile
unlikelyzero 53b4827
Reduce to one worker for stability
unlikelyzero d3c0170
Add test to cover new capabilities
unlikelyzero c1d76fe
lint fixes
unlikelyzero 843e553
Closes #7343
charlesh88 6a6538d
Closes #7343
charlesh88 fe4be25
Merge branch 'master' into confirmation-dialog-mobile
unlikelyzero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,20 +34,16 @@ Make no assumptions about the order that elements appear in the DOM. | |
*/ | ||
|
||
import { expect, test } from '../../pluginFixtures.js'; | ||
|
||
test('Verify that My Items Tree appears @mobile', async ({ page, openmctConfig }) => { | ||
const { myItemsFolderName } = openmctConfig; | ||
//Go to baseURL | ||
await page.goto('./'); | ||
|
||
//My Items to be visible | ||
await expect(page.getByRole('treeitem', { name: `${myItemsFolderName}` })).toBeVisible(); | ||
}); | ||
|
||
test('Verify that user can search @mobile', async ({ page }) => { | ||
//For now, this test is going to be hardcoded against './test-data/display_layout_with_child_layouts.json' | ||
await page.goto('./'); | ||
|
||
await page.getByRole('searchbox', { name: 'Search Input' }).click(); | ||
await page.getByRole('searchbox', { name: 'Search Input' }).fill('Parent Display Layout'); | ||
//Search Results appear in search modal | ||
|
@@ -57,3 +53,23 @@ test('Verify that user can search @mobile', async ({ page }) => { | |
await page.getByTitle('Collapse Browse Pane').click(); | ||
await expect(page.getByRole('main').getByText('Parent Display Layout')).toBeVisible(); | ||
}); | ||
test('Remove Object and confirmation dialog @mobile', async ({ page }) => { | ||
await page.goto('./'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can pull these |
||
await page.getByRole('searchbox', { name: 'Search Input' }).click(); | ||
await page.getByRole('searchbox', { name: 'Search Input' }).fill('Parent Display Layout'); | ||
//Search Results appear in search modal | ||
//Clicking on the search result takes you to the object | ||
await page.getByLabel('Object Results').getByText('Parent Display Layout').click(); | ||
await page.getByTitle('Collapse Browse Pane').click(); | ||
await expect(page.getByRole('main').getByText('Parent Display Layout')).toBeVisible(); | ||
//Verify both objects are in view | ||
await expect(await page.getByLabel('Child Layout 1 Layout')).toBeVisible(); | ||
await expect(await page.getByLabel('Child Layout 2 Layout')).toBeVisible(); | ||
//Remove First Object to bring up confirmation dialog | ||
await page.getByLabel('View menu items').nth(1).click(); | ||
await page.getByLabel('Remove').click(); | ||
await page.getByRole('button', { name: 'OK' }).click(); | ||
//Verify that the object is removed | ||
await expect(await page.getByLabel('Child Layout 1 Layout')).toBeVisible(); | ||
expect(await page.getByLabel('Child Layout 2 Layout').count()).toBe(0); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
driveby: reduce test flakiness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. yeah 1 should be enough here