Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Center Confirmation Dialog Texts #7492

Merged
merged 10 commits into from
Mar 3, 2024
Merged

[Mobile] Center Confirmation Dialog Texts #7492

merged 10 commits into from
Mar 3, 2024

Commits on Feb 22, 2024

  1. Make overlay messages centered

    @rukmini-bose
    rukmini-bose committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1d055ad View commit details
    Browse the repository at this point in the history

  2. Fix changes so that only dialogs and not forms are affected

    @rukmini-bose
    rukmini-bose committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    11990f0 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Fix buttons such that they are right-aligned

    @rukmini-bose
    rukmini-bose committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    864ba34 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Merge branch 'master' into confirmation-dialog-mobile

    @unlikelyzero
    unlikelyzero authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    88146a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Reduce to one worker for stability

    @unlikelyzero
    unlikelyzero committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    53b4827 View commit details
    Browse the repository at this point in the history

  2. Add test to cover new capabilities

    @unlikelyzero
    unlikelyzero committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d3c0170 View commit details
    Browse the repository at this point in the history

  3. lint fixes

    @unlikelyzero
    unlikelyzero committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c1d76fe View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Closes #7343 

    - Fixed an oversight that caused the top of form dialogs to
be scrolled out of view by default.
- Fixed approach to vertical centering for `-fit` type confirmation dialogs.
- Reduced size of confirmation dialog icons.
- Smoke tested in Chrome mobile emulator in a large variety of mobile
viewport sizes and orientations.
    @charlesh88
    charlesh88 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    843e553 View commit details
    Browse the repository at this point in the history

  2. Closes #7343 

    - Removes extra margin unintentionally added to `l-overlay-large`.
    @charlesh88
    charlesh88 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    6a6538d View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Merge branch 'master' into confirmation-dialog-mobile

    @unlikelyzero
    unlikelyzero authored Mar 3, 2024
    Configuration menu
    Copy the full SHA
    fe4be25 View commit details
    Browse the repository at this point in the history