Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Center Confirmation Dialog Texts #7492

Merged
merged 10 commits into from
Mar 3, 2024
Merged

[Mobile] Center Confirmation Dialog Texts #7492

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1d055ad
Make overlay messages centered
rukmini-bose Jan 22, 2024
11990f0
Fix changes so that only dialogs and not forms are affected
rukmini-bose Feb 9, 2024
864ba34
Fix buttons such that they are right-aligned
rukmini-bose Feb 26, 2024
88146a9
Merge branch 'master' into confirmation-dialog-mobile
unlikelyzero Feb 28, 2024
53b4827
Reduce to one worker for stability
unlikelyzero Feb 29, 2024
d3c0170
Add test to cover new capabilities
unlikelyzero Feb 29, 2024
c1d76fe
lint fixes
unlikelyzero Feb 29, 2024
843e553
Closes #7343
charlesh88 Mar 1, 2024
6a6538d
Closes #7343
charlesh88 Mar 1, 2024
fe4be25
Merge branch 'master' into confirmation-dialog-mobile
unlikelyzero Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/api/overlays/components/dialog-component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
.c-message {
display: flex;
align-items: center;

body.mobile & { // Centers confirmation dialog on screen.
margin-top: 40vh;
}
> * + * {
margin-left: $interiorMarginLg;
}
Expand Down
11 changes: 11 additions & 0 deletions src/api/overlays/components/overlay-component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@
display: flex;
flex-direction: column;
padding: $overlayInnerMargin;
body.mobile & { // Centers the overlay dialog for mobile
position: relative;
height: 100vh;
width: 100vw;
}
}

&__close-button {
Expand All @@ -45,6 +50,9 @@
flex-direction: column;
outline: none;
overflow: auto;
body.mobile & {
flex: none;
}
}

&__top-bar {
Expand Down Expand Up @@ -78,6 +86,9 @@
display: flex;
justify-content: flex-end;
margin-top: $interiorMargin;
body.mobile & {
justify-content: center;
}

> * + * {
margin-left: $interiorMargin;
Expand Down
Loading