-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure annotations on empty entries in notebook are not lost #6525
Ensure annotations on empty entries in notebook are not lost #6525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6525 +/- ##
==========================================
+ Coverage 54.74% 54.76% +0.01%
==========================================
Files 628 628
Lines 26802 26805 +3
Branches 2421 2422 +1
==========================================
+ Hits 14673 14680 +7
+ Misses 11465 11459 -6
- Partials 664 666 +2
*This pull request uses carry forward flags. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
… of github.com:nasa/openmct into 6156-annotations-on-empty-entries-in-notebook-are-lost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, but there are several references in this script to remove
openmct/e2e/tests/functional/plugins/notebook/tags.e2e.spec.js
Lines 134 to 135 in e57eedc
// TODO can be removed with fix for https://github.com/nasa/openmct/issues/6411 | |
await page.locator('[aria-label="Notebook Entry"].is-selected div.c-ne__text').click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #6156 #6411
Describe your changes:
Don't (sometimes) delete entries if text is empty. Select and focus entries when created.
All Submissions:
Author Checklist
Reviewer Checklist