First attempt at DeploySentinel and fix couchdb notebook tests #6398

unlikelyzero · 2023-03-06T22:18:18Z

WAIT FOR #6525

Describe your changes:

Adds deploysentinel to our CI configs
a quick driveby for cleaning up test files from gitignore
driveby documentation
driveby stability fixed for couchdb tests

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Command line build passes?
Has this been smoke tested?
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Reviewer has tested changes by following the provided instructions?
Changes appear not to be breaking changes?
Appropriate automated tests included?
Code style and in-line documentation are appropriate?
Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

deploysentinel · 2023-03-06T22:22:19Z

Current Playwright Test Results Summary

✅ 117 Passing - ❌ 1 Failing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/04/2023 11:50:04pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: b7310a9

Started: 04/04/2023 11:44:54pm UTC

❌ Failures

📄 framework/baseFixtures.e2e.spec.js • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
baseFixtures tests Verify that tests fail if console.error is thrown Initial Attempt Error: Error: Console error detected: [error] This should result in a failure at ( 0:14... `Error: Console error detected: [error] This should result in a failure at ( 0:14) Expected: not "error"`	100% (4) 4 / 4 runs failed over last 7 days	0% (0) 0 / 4 runs flaked over last 7 days

⚠️ Flakes

📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit Retry 1 • Initial Attempt	0% (0) 0 / 3 runs failed over last 7 days	33.33% (1) 1 / 3 run flaked over last 7 days

📄 functional/plugins/plot/overlayPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Overlay Plot Clicking on an item in the elements pool brings up the plot preview with data points Retry 1 • Initial Attempt	0% (0) 0 / 3 runs failed over last 7 days	100% (3) 3 / 3 runs flaked over last 7 days

View Detailed Build Results

codecov · 2023-03-06T22:27:02Z

Codecov Report

Merging #6398 (b7310a9) into master (2e60da0) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6398      +/-   ##
==========================================
- Coverage   54.90%   54.77%   -0.14%     
==========================================
  Files         628      628              
  Lines       26805    26805              
  Branches     2422     2422              
==========================================
- Hits        14718    14682      -36     
- Misses      11426    11457      +31     
- Partials      661      666       +5

Flag	Coverage Δ		*Carryforward flag
e2e-ci	`39.34% <ø> (ø)`		Carriedforward from 836b8bf
e2e-full	`51.06% <ø> (ø)`		Carriedforward from 836b8bf
e2e-stable	`55.78% <ø> (+0.37%)`	⬆️
unit	`48.93% <ø> (-0.35%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e60da0...b7310a9. Read the comment docs.

unlikelyzero · 2023-03-07T18:31:00Z

package.json

@@ -84,6 +85,7 @@
    "build:watch": "webpack --config ./.webpack/webpack.dev.js --watch",
    "info": "npx envinfo --system --browsers --npmPackages --binaries --languages --markdown",
    "test": "karma start",
+    "test:clean": "rm -rf ./coverage ./html-test-results ./test-results ./nyc_output/",


should be ./.nyc_output ?

…entinel

…ook-are-lost

…entinel

…s-in-notebook-are-lost' into deploysentinel

…entinel

ozyx

Looks good overall! Just have a few small suggestions

e2e/tests/functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js

e2e/tests/functional/forms.e2e.spec.js

e2e/helper/notebookUtils.js

e2e/tests/functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js

ozyx

LGTM

* First attempt * Remove commented pattern * Add deploysentinel to github action * drive by * Stablization * remove only * entries now selected on creation * select previous entry on deletion * add deletion test * wip * fix adding focus selection * remove previous entry selection logic * null check for event * address review comments * address review comments * refactor tests a bit * typo * Add some determinism to avoid console errors * refactor and use methods * stabilize * remove debug * remove only * combine clean commands * comments * change to expects * test: await toBeHidden() assertion * test: use `myItemsFolderName` instead of 'My Items' --------- Co-authored-by: Scott Bell <[email protected]> Co-authored-by: Jesse Mazzella <[email protected]>

First attempt

b844f86

unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 7, 2023

unlikelyzero added 2 commits March 7, 2023 10:26

Remove commented pattern

ea35ae8

Add deploysentinel to github action

73aac34

unlikelyzero removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 7, 2023

unlikelyzero requested a review from ozyx March 7, 2023 18:30

unlikelyzero added this to the Target:2.2.0 milestone Mar 7, 2023

unlikelyzero commented Mar 7, 2023

View reviewed changes

unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 7, 2023

unlikelyzero added 4 commits March 9, 2023 17:14

drive by

c1ee617

Stablization

7477259

Merge branch 'master' of https://github.com/nasa/openmct into deploys…

bf413a7

…entinel

remove only

33e67a7

unlikelyzero changed the title ~~First attempt at DeploySentinel~~ First attempt at DeploySentinel and some drivebys Mar 10, 2023

unlikelyzero added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Mar 10, 2023

unlikelyzero modified the milestones: Target:2.2.0, Target:2.2.1 Mar 14, 2023

unlikelyzero and others added 10 commits March 17, 2023 13:25

Merge branch 'master' of https://github.com/nasa/openmct into deploys…

2d6a173

…entinel

entries now selected on creation

c17177a

select previous entry on deletion

3a00c99

add deletion test

0d7b35b

wip

fcb46b0

fix adding focus selection

c561f24

remove previous entry selection logic

deb7dc3

Merge branch 'master' into 6156-annotations-on-empty-entries-in-noteb…

e310039

…ook-are-lost

Merge branch 'master' into 6156-annotations-on-empty-entries-in-noteb…

42818c0

…ook-are-lost

Merge branch 'master' into 6156-annotations-on-empty-entries-in-noteb…

5e77f9a

…ook-are-lost

scottbell and others added 11 commits March 31, 2023 10:57

address review comments

96ae28a

address review comments

42835a3

Merge branch 'master' into 6156-annotations-on-empty-entries-in-noteb…

54e082a

…ook-are-lost

refactor tests a bit

d768581

typo

e8ccd4c

Merge branch 'master' into 6156-annotations-on-empty-entries-in-noteb…

aec9ecc

…ook-are-lost

resolve conflicts

44d7c49

Add some determinism to avoid console errors

838749f

refactor and use methods

26551e7

stabilize

a204de4

Merge branch 'master' of https://github.com/nasa/openmct into deploys…

8de1a0f

…entinel

unlikelyzero requested a review from scottbell April 3, 2023 15:22

unlikelyzero marked this pull request as draft April 3, 2023 15:22

unlikelyzero changed the title ~~First attempt at DeploySentinel and some drivebys~~ First attempt at DeploySentinel and fix couchdb notebook tests Apr 3, 2023

scottbell and others added 3 commits April 3, 2023 17:39

Merge remote-tracking branch 'origin/6156-annotations-on-empty-entrie…

546bd1f

…s-in-notebook-are-lost' into deploysentinel

remove debug

a14a8d6

Merge branch 'master' of https://github.com/nasa/openmct into deploys…

8e47adf

…entinel

unlikelyzero marked this pull request as ready for review April 4, 2023 21:41

remove only

446e259

ozyx suggested changes Apr 4, 2023

View reviewed changes

unlikelyzero and others added 5 commits April 4, 2023 15:58

combine clean commands

94af4a6

comments

bce2daf

change to expects

836b8bf

test: await toBeHidden() assertion

60ca8e5

test: use myItemsFolderName instead of 'My Items'

b7310a9

ozyx approved these changes Apr 5, 2023

View reviewed changes

scottbell approved these changes Apr 5, 2023

View reviewed changes

unlikelyzero merged commit c0c383b into master Apr 5, 2023

unlikelyzero deleted the deploysentinel branch April 5, 2023 13:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First attempt at DeploySentinel and fix couchdb notebook tests #6398

First attempt at DeploySentinel and fix couchdb notebook tests #6398

unlikelyzero commented Mar 6, 2023 •

edited by scottbell

Loading

deploysentinel bot commented Mar 6, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

codecov bot commented Mar 6, 2023 •

edited

Loading

unlikelyzero Mar 7, 2023

ozyx Apr 4, 2023

ozyx left a comment

ozyx left a comment

First attempt at DeploySentinel and fix couchdb notebook tests #6398

First attempt at DeploySentinel and fix couchdb notebook tests #6398

Conversation

unlikelyzero commented Mar 6, 2023 • edited by scottbell Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

deploysentinel bot commented Mar 6, 2023 • edited Loading

Current Playwright Test Results Summary

❌ Failures

Test Case Results

⚠️ Flakes

Test Case Results

Test Case Results

codecov bot commented Mar 6, 2023 • edited Loading

Codecov Report

unlikelyzero Mar 7, 2023

Choose a reason for hiding this comment

ozyx Apr 4, 2023

Choose a reason for hiding this comment

ozyx left a comment

Choose a reason for hiding this comment

ozyx left a comment

Choose a reason for hiding this comment

unlikelyzero commented Mar 6, 2023 •

edited by scottbell

Loading

deploysentinel bot commented Mar 6, 2023 •

edited

Loading

codecov bot commented Mar 6, 2023 •

edited

Loading