Remove flask_uploads.py #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
force-pushed
the
discard-flask-uploads
branch
from
cc86bda
to
d90a8a4
Compare
|
Not sure what's up with the Unit tests, they pass locally... No need to merge this prior to v3.4 release |
thomas-bc
commented
Jan 10, 2024
LeStarch
approved these changes
Jan 18, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes nasa/fprime#2352
Removes the need for the flask_uploads.py module.
Additionally adds in a
--remote-sequence-directoryoption to control where sequence binaries are uploaded on the remote (default/seq, which is often not writeable when testing locally).