Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flask_uploads.py from the GDS #2352

Closed
thomas-bc opened this issue Oct 30, 2023 · 0 comments · Fixed by nasa/fprime-gds#152
Closed

Remove flask_uploads.py from the GDS #2352

thomas-bc opened this issue Oct 30, 2023 · 0 comments · Fixed by nasa/fprime-gds#152
Assignees
@thomas-bc
Labels
enhancement F´ GDS Issues pertaining to the F´ GDS
Milestone
Release v3.5.0

Comments

@thomas-bc
Copy link
Collaborator

F´ Version 3.3.x
Affected Component

Feature Description

flask_uploads.py is an old script that was forked from Flask, allowing to upload files. It shouldn't be necessary to keep it anymore.
We should remove it, and keep only the minimal set of functionality that fits the use case.
Preliminary work has been done here: https://github.com/fprime-community/fprime-gds/tree/discard-flask-uploads
I believe this is working - just need to confirm, test and polish the branch before opening a PR.
@thomas-bc thomas-bc added enhancement F´ GDS Issues pertaining to the F´ GDS labels Oct 30, 2023
@thomas-bc thomas-bc self-assigned this Oct 30, 2023
@thomas-bc thomas-bc added this to the Release v3.5.0 milestone Nov 16, 2023
@thomas-bc thomas-bc mentioned this issue Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas-bc thomas-bc

Labels
enhancement F´ GDS Issues pertaining to the F´ GDS
Projects
None yet
Milestone
Release v3.5.0
Development

Successfully merging a pull request may close this issue.

Remove flask_uploads.py nasa/fprime-gds
1 participant
@thomas-bc