From nsidc cumulus 3220: Create a new send-pan task #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `cumulus/packages/pvl` the exports were located in `t.js` and
`index.js` was empty. This was causing a dependency failure in
`cumulus/packages/api/models/pdrs.js`, which uses
`require('@cumulus/pvl')`.
At the same time, `cumulus/tasks/parse-pdr/index.js` had been
configured to use `require('@cumulus/pvl/t')` in order to get around
the empty PVL `index.js` file.
This commit moves `t.js` to `index.js` and updates the `require` in
the parse-pdr task.
Downgrade the `got` package to 11.8.6. The 12.x version was converted to native ESM and no longer supports CommonJS `require`.
NDCUM-914
Fixed pdr replacement so we replace only instances of .pdr
* Update xml2js 0.4.22->0.5 strict * Address GHSA-776f-qx25-q3cc/update allow list * Update CHANGELOG * Update package pins to 0.5.0 for xmljs Co-authored-by: Jonathan Kovarik <[email protected]>
…horization header (#3341) * CUMULUS-3285: Updated isAuthBearTokenRequest to handle non-Bearer authorization header * add integration test
Release 15.0.1
* backport PR * finalizing docs and changing remaining groups * 15.1.0 release * doc updates * PR feedback + testing changes * Revert "doc updates" This reverts commit 5037012. * PR feedback * reverting change * Revert "update changelog" This reverts commit ae4627c. * reverting changes * PR feedback * removing EgressLambda from doc * Update xml2js 0.4.22->0.5 strict (#3330) (#3339) * Update xml2js 0.4.22->0.5 strict * Address GHSA-776f-qx25-q3cc/update allow list * Update CHANGELOG * Update package pins to 0.5.0 for xmljs Co-authored-by: Jonathan Kovarik <[email protected]> * PR feedback * PR feedback * PR feedback * fixing documentation linting * PR feedback * PR feedback * PR feedback * adding variables to tf-modules/workflow * PR feedback * PR feedback * reverting previous change * CUMULUS-3121/3120 v15.1.0 backport (#3346) * backport PR * finalizing docs and changing remaining groups * PR feedback + testing changes * PR feedback * reverting change * Revert "update changelog" This reverts commit ae4627c. * reverting changes * PR feedback * removing EgressLambda from doc * Update xml2js 0.4.22->0.5 strict (#3330) (#3339) * Update xml2js 0.4.22->0.5 strict * Address GHSA-776f-qx25-q3cc/update allow list * Update CHANGELOG * Update package pins to 0.5.0 for xmljs Co-authored-by: Jonathan Kovarik <[email protected]> * PR feedback * PR feedback * PR feedback * fixing documentation linting * PR feedback * PR feedback * PR feedback * adding variables to tf-modules/workflow * PR feedback * PR feedback * reverting previous change --------- Co-authored-by: jennyhliu <[email protected]> Co-authored-by: Jonathan Kovarik <[email protected]> * changing version number * small fixes * small fix --------- Co-authored-by: jennyhliu <[email protected]> Co-authored-by: Jonathan Kovarik <[email protected]>
* CUMULUS-3243:Updated granule delete logic to delete granule which is not in DynamoDB * add unit tests
Release 15.0.3
botanical
reviewed
Jul 26, 2023
| Key: panKey, | ||
| }); | ||
| expect(panExists).toEqual(true); | ||
| deleteS3Object(config.bucket, panKey); |
There was a problem hiding this comment.
Suggested change
| deleteS3Object(config.bucket, panKey); | |
| await deleteS3Object(config.bucket, panKey); |
botanical
reviewed
Jul 26, 2023
botanical
reviewed
Jul 26, 2023
botanical
reviewed
Jul 26, 2023
| * @param {object} params | ||
| * @param {string} params.localPath - the full local file path | ||
| * @param {string} params.uploadPath - the full remote file path for uploading file to | ||
| * @param {string} params.remoteAltBucket - alternate per-file bucket override to this.bucket |
There was a problem hiding this comment.
Suggested change
| * @param {string} params.remoteAltBucket - alternate per-file bucket override to this.bucket | |
| * @param {string} [params.remoteAltBucket] - alternate per-file bucket override to this.bucket |
botanical
reviewed
Jul 26, 2023
botanical
reviewed
Jul 26, 2023
botanical
reviewed
Jul 26, 2023
botanical
reviewed
Jul 26, 2023
botanical
reviewed
Jul 26, 2023
botanical
reviewed
Jul 26, 2023
botanical
reviewed
Jul 26, 2023
botanical
reviewed
Jul 26, 2023
tasks/send-pan/src/index.ts
Outdated
| * | ||
| * @param {object} event - a Cumulus Message | ||
| * @param {object} context - an AWS Lambda context | ||
| * @returns {Promise<object>} - Returns output from task. |
There was a problem hiding this comment.
Suggested change
| * @returns {Promise<object>} - Returns output from task. | |
| * @returns {Promise<CumulusMessageWithAssignedPayload | CumulusRemoteMessage>} - Returns output from task. |
I believe it should be returning a CumulusMessage?
botanical
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-3220: Create a new send-pan task for use in SIPS workflows
Original user PR: #3320
Changes
PR Checklist