Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #24, Enforce standard style in CI #28

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 2, 2020

Describe the contribution
Fix #24 - CI enforcement of style

Testing performed
See CI results - no independent testing required

Expected behavior changes
Style enforced, CI will fail if new pull request does not meet expected style.

System(s) tested on:

Additional context
None

Contributor Info
Jacob Hagement - NASA/GSFC

@skliper skliper force-pushed the fix24-standard-format branch 2 times, most recently from e9fe1d7 to a473959 Compare January 6, 2020 20:42
@skliper skliper force-pushed the fix24-standard-format branch from a473959 to 041f426 Compare January 6, 2020 20:48
@skliper skliper changed the title Apply standard style Enforce standard style in CI Jan 6, 2020
@skliper
Copy link
Contributor Author

skliper commented Jan 6, 2020

Note it requires #30 to be merged before it will pass.

@skliper skliper added the CCB:Approved Indicates code approval by CCB label Jan 14, 2020
@skliper
Copy link
Contributor Author

skliper commented Jan 14, 2020

CCB 20200108 - reviewed and approved for IC branch

@skliper skliper changed the base branch from master to ic-20200108 January 14, 2020 21:39
@skliper skliper changed the title Enforce standard style in CI Fix #24, Enforce standard style in CI Jan 14, 2020
@skliper skliper merged commit d46de5f into ic-20200108 Jan 14, 2020
@astrogeco astrogeco deleted the fix24-standard-format branch March 13, 2020 14:03
@skliper skliper added this to the 2.4.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant