Fix #112, update cmake_minimum_required #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This triggers a warning because support for old versions will be removed The build does not actually expect such an old version
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jun 28, 2022
|
EDIT: I read 3.2, not 3.20... disregard comment. |
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 7, 2022
*Combines:* osal v6.0.0-rc4+dev93 ci_lab v2.5.0-rc4+dev22 to_lab v2.5.0-rc4+dev24 sch_lab v2.5.0-rc4+dev31 **Includes:** - nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES *Update Minimum CMake Version* - nasa/osal#1267, Update minimum required cmake version - nasa/ci_lab#113, update cmake_minimum_required - nasa/sch_lab#117, update cmake_minimum_required Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
This was referenced Jul 7, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 8, 2022
*Combines:* osal v6.0.0-rc4+dev93 ci_lab v2.5.0-rc4+dev22 to_lab v2.5.0-rc4+dev24 sch_lab v2.5.0-rc4+dev31 **Includes:** - nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES *Update Minimum CMake Version* - nasa/osal#1267, Update minimum required cmake version - nasa/ci_lab#113, update cmake_minimum_required - nasa/sch_lab#117, update cmake_minimum_required Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes the warning that support for old versions will be removed
The build does not actually expect such an old version
Fixes #112
Testing performed
Build using CMake 3.20
Expected behavior changes
No more deprecation warning
System(s) tested on
RHEL 8
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.