Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake mimimum required to something more recent #112

Closed
jphickey opened this issue Jun 28, 2022 · 0 comments · Fixed by #113 or #114
Closed

Update cmake mimimum required to something more recent #112

jphickey opened this issue Jun 28, 2022 · 0 comments · Fixed by #113 or #114

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The cmake_minimum_required command currently lists a very old version. In fact some of the CFE/CFS build scripts assume at least version 3.5 to support things like target-specific includes and flags.

Notably, when using a recent version of cmake (e.g. 3.20) this generates a warning that says:

CMake Deprecation Warning at /home/jphickey/code/cfecfs/dtn/apps/ci_lab/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Describe the solution you'd like
Update the cmake_minimum_version to 3.5 (this would match CFE)

Describe alternatives you've considered
Disable warning?

Requester Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit to jphickey/ci_lab that referenced this issue Jun 28, 2022
This triggers a warning because support for old versions will be removed
The build does not actually expect such an old version
dzbaker added a commit that referenced this issue Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant