Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #530, Default CI to bash to apply pipefail #531

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jul 27, 2022

Checklist (Please check before submitting)

Describe the contribution

Without the bash pipefail option return codes can get masked
missing failures. Specifically seen in the unit test reusable
workflow where ctest returns were masked. By forcing
the default shell as bash, GitHub applies the pipefail option.

Testing performed
CI

Also tested from cf with https://github.com/skliper/CF/runs/7543285379?check_suite_focus=true (pointing to this branch) to confirm the failed ctest causes the CI to fail.

Expected behavior changes
Any failure in a pipeline will fail the CI step

System(s) tested on
CI

Additional context
Originally seen in CF

Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

Without the bash pipefail option return codes can get masked
missing failures.  Specifically seen in the unit test reusable
workflow where ctest returns were masked.  By forcing
the default shell as bash, GitHub applies the pipefail option.
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jul 27, 2022
@skliper skliper added this to the Draco milestone Jul 27, 2022
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jul 27, 2022
@dzbaker dzbaker mentioned this pull request Jul 28, 2022
2 tasks
@dzbaker dzbaker merged commit 0a530aa into nasa:main Jul 28, 2022
@skliper skliper deleted the fix530-bash_yml_pipefail branch September 19, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test CI not failing when tests fail
2 participants