Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test CI not failing when tests fail #530

Closed
3 tasks done
skliper opened this issue Jul 26, 2022 · 0 comments · Fixed by #531
Closed
3 tasks done

Unit test CI not failing when tests fail #530

skliper opened this issue Jul 26, 2022 · 0 comments · Fixed by #531
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Jul 26, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the CF README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
https://github.com/nasa/CF/runs/7455025036?check_suite_focus=true

The test failed but the unit test CI reported as passed.

Describe the solution you'd like
Failed test needs to fail CI

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper transferred this issue from nasa/CF Jul 27, 2022
@skliper skliper self-assigned this Jul 27, 2022
@skliper skliper added this to the Draco milestone Jul 27, 2022
dzbaker added a commit that referenced this issue Jul 28, 2022
Fix #530, Default CI to bash to apply pipefail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant