Fix #264, CodeQL Dependent on a Successful Build

[ArielSAdamsNASA]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License agreement to [email protected] and copied [email protected].

Describe the contribution
Fixes #264
Added workflow_run event as a trigger.

Testing performed
Tested on fork. Triggered on workflow_run. Will work once workflow is integrated in main.

Expected behavior changes
If Build, Test, and Run [OMIT_DEPRECATED=true] fails, then CodeQL will not run.

Additional context
https://stackoverflow.com/questions/62750603/github-actions-trigger-another-action-after-one-action-is-completed
Build, Test, and Run [OMIT_DEPRECATED=true] must be renamed.

Tried

    workflows: 
      - 'Build, Test, and Run [OMIT_DEPRECATED=true]'

    workflows: 
      - Build, Test, and Run [OMIT_DEPRECATED=true]

    workflows: ["Build, Test, and Run [OMIT_DEPRECATED=true]"]

Build, Test, and Run name works.

Downside is that CodeQL workflow does not name what triggered the workflow such as the name of the commit. Instead it always says the name of the workflow which is CodeQL Analysis.

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

[astrogeco]

I wonder if we can skip the tests altogether. Also, look into making the CodeQL workflow dependent on the "build and run" one https://github.com/marketplace/actions/workflow-run-conclusion-dispatch-action

[ArielSAdamsNASA]

@astrogeco Can you specify what you mean by the build and run one? Like the workflow or a job?

[astrogeco]

@astrogeco Can you specify what you mean by the build and run one? Like the workflow or a job?

Sorry, meant the build and run workflow

[ArielSAdamsNASA]

@astrogeco Can you specify what you mean by the build and run one? Like the workflow or a job?

Sorry, meant the build and run workflow

So, build-cfs-deprecated.yml or build-cfs.yml?

I feel like it would be best to just build and run cFS in jobs.

I don't quite understand the action you provided and the workflow_run trigger isn't working.

https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_run

This event will only trigger a workflow run if the workflow file is on the default branch.

[astrogeco]

The idea was to wait for the build and test workflow defined in build-cfs.yml to successfully execute and avoid building cFS multiple times in different workflows. It might not be worth the complexity though.

[astrogeco]

Are we sure this won't run twice without the check?

[ArielSAdamsNASA]

CodeQL is only triggered on workflow_run, but I can keep the check there for now.

[astrogeco]

CCB:2021-07-21 APPROVED