Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #67, Remove mission_inc reference #68

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix #67, Remove mission_inc reference #68

merged 1 commit into from
Apr 21, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Mar 31, 2020 •
edited
Loading

Describe the contribution
Fix #67
Refactored search path for defines

Testing performed
Steps taken to test the contribution:

  1. Did not rebuild all references... but the next time it's done this search path should work better

Expected behavior changes
Should find all references

System(s) tested on
N/A

Additional context
nasa/cFE#577

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the enhancement New feature or request label Mar 31, 2020
@skliper skliper added this to the 2.2.0 milestone Mar 31, 2020
@skliper
Copy link
Contributor Author

skliper commented Mar 31, 2020

@dmknutsen did you ever use these tools to build the "pickle" files? If so could you see if this fix works?

@skliper skliper requested a review from dmknutsen March 31, 2020 22:11
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 9, 2020
@skliper
Copy link
Contributor Author

skliper commented Apr 15, 2020

CCB 20200415 - APPROVED

@astrogeco astrogeco added CCB:Approved Indicates approval by CCB CCB - 20200415 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 20, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 21, 2020 22:10
@astrogeco astrogeco merged commit 7dd9675 into nasa:integration-candidate Apr 21, 2020
@astrogeco astrogeco mentioned this pull request Apr 27, 2020
Merged
@skliper skliper deleted the fix67-rm-mission-inc-ref branch February 1, 2021 21:17
@skliper skliper mentioned this pull request Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmknutsen dmknutsen Awaiting requested review from dmknutsen

Assignees
No one assigned
Labels
CCB:Approved Indicates approval by CCB enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Remove reference to cfe/fsw/mission_inc
2 participants
@skliper @astrogeco