Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #344, Remove mission/platform include dirs #577

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Mar 31, 2020

Describe the contribution
Fixes #344
Removes classic build directories.

Testing performed
Steps taken to test the contribution:

  1. Tested w/ CI bundle branch on fork, see: https://travis-ci.com/github/skliper/cFS/builds/157335615

Expected behavior changes
None, reduces user confusion due to duplicate defines

System(s) tested on

  • Hardware: CI (AMD)
  • OS: Ubuntu 18.04
  • Versions: Master w/ this commit

Additional context
Only dependence found in framework was in cFS-GroundStation. See XXX

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 6.8.0 milestone Mar 31, 2020
jphickey pushed a commit to jphickey/cFE that referenced this pull request Apr 2, 2020
Documentation changes only
lbleier-GSFC pushed a commit to lbleier-GSFC/cFE that referenced this pull request Apr 6, 2020
Documentation changes only
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 9, 2020
@astrogeco
Copy link
Contributor

CCB 20200415 - APPROVED

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB CCB - 20200415 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 20, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 21, 2020 22:17
@astrogeco astrogeco merged commit 0cd9f5e into nasa:integration-candidate Apr 21, 2020
@skliper skliper deleted the fix344-rm-mission-platform-inc branch February 1, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fsw/mission_inc and fsw/platform_inc (classic build support)
2 participants