Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #65, CCSDS Command Secondary Header Endian Agnostic #66

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fix #65, CCSDS Command Secondary Header Endian Agnostic #66

merged 1 commit into from
Apr 6, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Mar 25, 2020

Describe the contribution
Implement CCSDS command secondary header such that it is endian agnostic. Really just sets command code appropriately.
Fix #65

Testing performed
Steps taken to test the contribution:

  1. Tested via bundle CI (including non-zero command send to reset)
  2. Also tested locally with enabling TO via cFS-GroundSystem

This covered both direct cmdUtil call and cFS-GroundSystem use.

Expected behavior changes
Cmd code (and checksum) are always in the same place (matches GSFC spec for command secondary header)

System(s) tested on

Additional context
See also nasa/cFE#568, these two should be merged together

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper
Fix nasa#65, CCSDS sec cmd hdr consistancy
6a981d9 
Implement CCSDS command secondary header such that it
is endian agnostic.  Really just sets command code
appropriately.
@skliper skliper added the bug Something isn't working label Mar 25, 2020
@skliper skliper added this to the 2.2.0 milestone Mar 25, 2020
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Mar 25, 2020
@skliper skliper mentioned this pull request Mar 25, 2020
Merged
@astrogeco
Copy link
Contributor

CCB 2020-04-01 - Approved

@astrogeco astrogeco added CCB - 20200401 CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 1, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 6, 2020 17:43
@astrogeco astrogeco merged commit a9c3cab into nasa:integration-candidate Apr 6, 2020
@astrogeco astrogeco mentioned this pull request Apr 9, 2020
Merged
@skliper skliper mentioned this pull request Apr 9, 2020
Closed
@skliper skliper deleted the fix65-sec-cmd-hdr branch February 1, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CCB:Approved Indicates approval by CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Make command secondary header endian agnostic (match GSFC spec)
2 participants
@skliper @astrogeco