Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #297, CCSDS Command Secondary Header Endian Agnostic #568

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Mar 25, 2020

Describe the contribution
Implement CCSDS command secondary header such that it is endian agnostic in code and unit test support.
Fix #297

Testing performed
Steps taken to test the contribution:

  1. Tested via bundle CI (including non-zero command send to reset)
  2. Also tested locally with enabling TO via cFS-GroundSystem

This covered both direct cmdUtil call and cFS-GroundSystem use.

Expected behavior changes
Cmd code (and checksum) are always in the same place (matches GSFC spec for command secondary header)

System(s) tested on

Additional context
See also nasa/cFS-GroundSystem#66 these should be merged together

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

Implement CCSDS command secondary header such that it
is endian agnostic in code and unit test support.
@skliper skliper added the bug label Mar 25, 2020
@skliper skliper added this to the 6.8.0 milestone Mar 25, 2020
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Mar 25, 2020
@skliper
Copy link
Contributor Author

skliper commented Mar 25, 2020

@BaldBeacon @tngo67 - ping.

*EDIT - tagged wrong person.

@astrogeco
Copy link
Contributor

astrogeco commented Apr 1, 2020

CCB 2020-04-01 - Discussed. Will break systems that are little endian as happened in a previous cFE version. Users who need this functionality can apply the diff. APPROVED

@astrogeco astrogeco added CCB - 20200401 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 1, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 6, 2020 17:45
@astrogeco astrogeco merged commit ff3aa94 into nasa:integration-candidate Apr 6, 2020
@skliper skliper deleted the fix297-cmd-sec-hdr branch February 1, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CCSDS secondary header consistency update
2 participants