Fix #189, Virtualenv and Pipenv .gitignore support #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this really needs to be in the project |
|
Ok, then I'll close this PR. |
That was quick ... may want to get some other opinions on the matter before closing ... I'm not necessarily opposed to the venv/pycache stuff, since its likely that these files will get created no matter what IDE the user chooses. |
|
Ok, I just thought that would take care of the whole .gitignore change thing. I can just throw out the IDE thing in a new commit and leave the venv thing in. |
paulober
changed the title
astrogeco
added
CCB:Ready
astrogeco
reviewed
Aug 25, 2021
|
CCB:2021-08-25 APPROVED
|
Structured .gitignore
astrogeco
approved these changes
Aug 30, 2021
astrogeco
force-pushed
the
integration-candidate
branch
from
27f49b8
to
dd9859c
Compare
paulober
deleted the
fix-189-jetbrainside-venv-pipenv-support-gitignore
branch
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2021
… support nasa/cFS-GroundSystem#194, Fix doc, comment, and message typos
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2021
**Combines** nasa/cFE#1885, v6.8.0-rc1+dev980 nasa/osal#1138, v5.1.0-rc1+dev598 nasa/cFS-GroundSystem#195, v2.2.0-rc1+dev63 **Includes** *cFE* nasa/cFE#1870, Add SB API test cases nasa/cFE#1869, Add ES API test cases nasa/cFE#1872, Add TBL API test cases nasa/cFE#1871, Add FS API test cases nasa/cFE#1860, Add Time Clock Test nasa/cFE#1862, EVS coverage test nasa/cFE#1876, SB test improvements nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag nasa/cFE#1881, Improve EVS code coverage nasa/cFE#1877, add call to CFE_ES_ExitChildTask nasa/cFE#1902, Incorrect OSAL Format in Users Guide Reference nasa/cFE#1884, Improve FS coverage nasa/cFE, Improve MSG branch coverage nasa/cFE#1891, Improve resource ID branch coverage nasa/cFE#1894, Improve SBR branch coverage nasa/cFE#1896, Fix #1895, Improve TIME branch coverage nasa/cFE#1904, Improve TBL code coverage nasa/cFE#1864, Support custom PSP directory nasa/cFE#1913, Update time tests to use bitmask check macros nasa/cFE#1923, remove extra word in comment *osal* nasa/osal#1136, add bitmask assert macros *cFS-GroundSystem* nasa/cFS-GroundSystem#190, Fix #189, Virtualenv and Pipenv .gitignore support nasa/cFS-GroundSystem#194, Fix doc, comment, and message typos Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Ariel Adams <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]> Co-authored-by: Avi <[email protected]> Co-authored-by: Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structured .gitignore
Describe the contribution
Testing performed
Contributor Info - All information REQUIRED for consideration of pull request
Paul Oberosler, Individual