cFE Integration candidate: 2021-08-31 #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds SB functional test cases to cover all missing items that were identified as part of the scrub in issue #1724. Where a specific condition is not testable because it requires a failure of another subsystem, it is marked as `covtest` to indicate it is only verifiable in coverage test environment.
Adds ES functional test cases to cover all missing items that were identified as part of the scrub in issue #1724. Where a specific condition is not testable because it requires a failure of another subsystem, it is marked as `covtest` to indicate it is only verifiable in coverage test environment.
Adds FS functional test cases to cover all missing items that were identified as part of the scrub in issue #1724. Where a specific condition is not testable because it requires a failure of another subsystem, it is marked as `covtest` to indicate it is only verifiable in coverage test environment.
Adds TBL functional test cases to cover all missing items that were identified as part of the scrub in issue #1724. Where a specific condition is not testable because it requires a failure of another subsystem, it is marked as `covtest` to indicate it is only verifiable in coverage test environment.
Fix #1812, Add SB API test cases
Fix #1866, Add ES API test cases
Fix #1868, Add TBL API test cases
Fix #1867, Add FS API test cases
Use the CFE_SB_PEND_FOREVER flag on a few of the calls to CFE_SB_ReceiveBuffer to confirm that this works as expected. Previously only CFE_SB_POLL and a nonzero timeout were used. Note this can only be used when it is known/expected that the message queue is not empty. If there is any possiblility that the queue is empty, then this cannot be used or else the test may block. This also means that if the test fails, it may fail by blocking and never finishing the test rather than an actual FAIL testcase.
Add test cases to confirm that when multiple pipes are subscribed to the same message ID, that: 1. Broadcasting (transmit side) is successful even if some of the pipes are not deliverable. 2. MsgLimit (from subscription) and PipeDepth (from pipe create) are honored. 3. If some pipes are undeliverable for any reason, delivery to open pipes is not affected.
Extends the broadcast test case to cover unsubscription of a single pipe ID. Confirms that other pipes/subscriptions are not affected, and that the limits initially enforced on those original subscriptions still apply.
Add test cases to the zero copy sequence to confirm proper override and/or increment of the sequence count.
Invoke CFE_ES_ExitChildTask from the main test task, to confirm that the task does not actually exit. There is no status code but the fact that the test keeps running is evidence that the task did not exit (which means the test passed).
2 tasks
Fix #1769, add call to CFE_ES_ExitChildTask
Replace UtAssert_UINT32_EQ with bitmask-specific check macros
…-format-users-guide-reference Fix #1616, Incorrect OSAL Format in Users Guide Reference
Fix #1880, Improve FS coverage
Fix #1888, Improve MSG branch coverage
Fix #1890, Improve resource ID branch coverage
Fix #1893, Improve SBR branch coverage
Fix #1895, Improve TIME branch coverage
astrogeco
force-pushed
the
integration-candidate
branch
from
f11b728
to
811d1fd
Compare
astrogeco
force-pushed
the
integration-candidate
branch
from
53a0730
to
74320c3
Compare
|
Failing test is due to osal dependency see nasa/cFS#348 for working bundle, test should work once osal and cfe are merged into main |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2021
**Combines** nasa/cFE#1885, v6.8.0-rc1+dev980 nasa/osal#1138, v5.1.0-rc1+dev598 nasa/cFS-GroundSystem#195, v2.2.0-rc1+dev63 **Includes** *cFE* nasa/cFE#1870, Add SB API test cases nasa/cFE#1869, Add ES API test cases nasa/cFE#1872, Add TBL API test cases nasa/cFE#1871, Add FS API test cases nasa/cFE#1860, Add Time Clock Test nasa/cFE#1862, EVS coverage test nasa/cFE#1876, SB test improvements nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag nasa/cFE#1881, Improve EVS code coverage nasa/cFE#1877, add call to CFE_ES_ExitChildTask nasa/cFE#1902, Incorrect OSAL Format in Users Guide Reference nasa/cFE#1884, Improve FS coverage nasa/cFE, Improve MSG branch coverage nasa/cFE#1891, Improve resource ID branch coverage nasa/cFE#1894, Improve SBR branch coverage nasa/cFE#1896, Fix #1895, Improve TIME branch coverage nasa/cFE#1904, Improve TBL code coverage nasa/cFE#1864, Support custom PSP directory nasa/cFE#1913, Update time tests to use bitmask check macros nasa/cFE#1923, remove extra word in comment *osal* nasa/osal#1136, add bitmask assert macros *cFS-GroundSystem* nasa/cFS-GroundSystem#190, Fix #189, Virtualenv and Pipenv .gitignore support nasa/cFS-GroundSystem#194, Fix doc, comment, and message typos Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Ariel Adams <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]> Co-authored-by: Avi <[email protected]> Co-authored-by: Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
PR #1870
PR #1869
PR #1872
PR #1871
PR #1860
PR #1862
EVS Coverage
PR #1876
SB test improvements
PR #1865
PR#1881
PR #1877,
PR #1884
PR #1889
PR #1891,
PR #1894
PR #1904
Improve TBL code coverage
PR #1864
PR #1913
Testing performed
Ubuntu CI
cFE Checks https://github.com/nasa/cFE/pull/1885/checks
cFS Bundle Checks https://github.com/nasa/cFS/pull/348/checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu CI
RTEMS CI (cFS bundle)
Additional context
Part of nasa/cFS#348
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@skliper
@pepepr08
@ArielSAdamsNASA
@jbohren-hbr
@zanzaben