Fix #851, Pass aligned message into CFE_MSG_ComputeCheckSum

[skliper]

Describe the contribution
Fix #851 - Fixes the cast-align error (use the aligned Msg since it's available already)

Testing performed
Standard build and unit test, passes

Expected behavior changes
No more alignment error

System(s) tested on

• Hardware: cFS Dev Server
• OS: Ubuntu 18.04
• Versions: bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

[skliper]

@hukuzatuna - Could you check if this resolves #851?

[skliper]

@hukuzatuna - standby, now I remember why I did that (to avoid the cppcheck warning). Let me fix both first.

[hukuzatuna]

Standing by. (It fixed the first error, but now it throws the same error on SendUdp.c under the cFS-GroundSystem directory. I assume your fix will address all of them, so continuing to stand by.)

[hukuzatuna]

Fixed in cfe_msg_sechdr_checksum.c, but now throwing the same error in SendUdp under the cFS-GroundSystem directory:

Scanning dependencies of target cmdUtil
[ 14%] Building C object tools/cFS-GroundSystem/Subsystems/cmdUtil/CMakeFiles/cmdUtil.dir/cmdUtil.c.o
[ 28%] Building C object tools/cFS-GroundSystem/Subsystems/cmdUtil/CMakeFiles/cmdUtil.dir/SendUdp.c.o
/home/pi/src/NASA/cFS/tools/cFS-GroundSystem/Subsystems/cmdUtil/SendUdp.c: In function ‘SendUdp’:
/home/pi/src/NASA/cFS/tools/cFS-GroundSystem/Subsystems/cmdUtil/SendUdp.c:94:23: error: cast increases required alignment of target type [-Werror=cast-align]
            inet_ntoa(((struct sockaddr_in *)result->ai_addr)->sin_addr), port);
                       ^
cc1: all warnings being treated as errors
make[7]: *** [tools/cFS-GroundSystem/Subsystems/cmdUtil/CMakeFiles/cmdUtil.dir/build.make:76: tools/cFS-GroundSystem/Subsystems/cmdUtil/CMakeFiles/cmdUtil.dir/SendUdp.c.o] Error 1
make[6]: *** [CMakeFiles/Makefile2:468: tools/cFS-GroundSystem/Subsystems/cmdUtil/CMakeFiles/cmdUtil.dir/all] Error 2
make[5]: *** [Makefile:141: all] Error 2
make[4]: *** [CMakeFiles/mission-all.dir/build.make:57: CMakeFiles/mission-all] Error 2
make[3]: *** [CMakeFiles/Makefile2:170: CMakeFiles/mission-all.dir/all] Error 2
make[2]: *** [CMakeFiles/Makefile2:177: CMakeFiles/mission-all.dir/rule] Error 2
make[1]: *** [Makefile:214: mission-all] Error 2
make: *** [Makefile:120: all] Error 2
pi@renegade:~/src/NASA/cFS $ 

Should I open another issue, or just track this category here?

[skliper]

I was able to bring up a system with a new enough gcc to do cast-align=strict. I'll write issues if they don't exist already.

[astrogeco]

CCB 2020-09-02 APPROVED