Integration Candidate 20200121 #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a "global_build_options.cmake" file akin to the existing arch_build/mission_build option files. Include an example of this file that optionally does add_definitions() to omit the deprected elements for build testing.
Add extra compile options for mission scope and arch scope. These are separated to support cross compile environments that do not/cannot use the same flags on both builds. For "mission" build the targets are never cross compiled, only built for the native host machine. It should be safe to assume a compiler in the GCC family and the strict warnings should _always_ be applicable here. For "arch" build the options are compiler vendor dependent. The file as-supplied can only be used if all the target cross compilers are in the same family and support the same warning options. However, this file can be modified without affecting the options used for the host side tools.
Add a _custom suffix to differentiate the customization file from the base file in the cmake directory.
Include in the basic warning set. Note that at this time the CFE does not build cleanly on all architectures with this warning enabled, pending resolution of issue #313.
Adds logic and associated unit tests Removes no-longer-used EID
Fix #101, Always increment sequence counter
Fix #412, Clean up table services comments/references
Fix #459, resolve doxygen obsolete warning
Fix #24, Add compiler option examples
Fix #355, Add global scope option to omit deprecated items
Fix #189, Unit test for cfe_evs_task.c
|
CCB 20200122 - Reviewed and approved for merge to master |
skliper
added
the
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #459, fix #355, fix, #24, fix #101, fix #412, fix #189
Testing performed
Steps taken to test the contribution:
Expected behavior changes
System(s) tested on
Additional context
N/A
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC