Fix #101, Always increment sequence counter

[CDKnightNASA]

Describe the contribution

• Fix SB Only Increments Message Sequence Count Where There are Subscribers #101

Note that this means route entries will never be removed and unsubscribe messages will never be sent.

Testing performed
Built and ran the SB unit tests. All passed, with changes included in this pull req.

Expected behavior changes
Sequence ID's of messages should increment even when there's (currently) no subscribers to that message ID.

System(s) tested on:
Debian VM

Contributor Info
[email protected]

[skliper]

Could remove or mark CFE_SB_UNSUBSCRIPTION_RPT_EID as no longer generated.

[skliper]

Remove CFE_SB_UNSUBSCRIPTION_RPT_EID (I think this was the CCB decision?)

[CDKnightNASA]

Remove CFE_SB_UNSUBSCRIPTION_RPT_EID (I think this was the CCB decision?)

will do

[CDKnightNASA]

I believe I've properly squashed the branch, removed the unused EID, added unit tests...anything else?

FYI for me what worked:

% git checkout branch
% git log # look for the first SHA before the branch
% git reset --soft SHA
% git commit -m 'new commit msg'
% git push origin +branch

[skliper]

CCB 20200115 - Reviewed and approved for IC pending the changes already addressed above

[skliper]

Updated commit message (no code change)